From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
castet.matthieu@free.fr, sfr@canb.auug.org.au,
tglx@linutronix.de, rjw@sisk.pl
Subject: Re: [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file
Date: Fri, 18 Feb 2011 09:42:14 -0800 [thread overview]
Message-ID: <4D5EAF76.6080301@linux.intel.com> (raw)
In-Reply-To: <AANLkTikxqk=HEw9R-Du=v-1ti1HDGAY9vaNUep2XARaz@mail.gmail.com>
On 02/18/2011 04:31 AM, Brian Gerst wrote:
>> +
>> + /* Patch post-real-mode segment jump */
>> + movw dispatch_table(%ebx,%ecx,2),%cx
>> + movw %cx, 101f(%ebx)
>> + movw %ax, 102f(%ebx)
>
> This looks wrong. The type parameter is in %eax, not %ecx, and this
> code is expecting %eax to be a segment.
>
You're quite right. I decided to make a change, changed all the
invocations, and forgot to change the actual code. D'oh!
-hpa
next prev parent reply other threads:[~2011-02-18 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 4:56 [RFC] x86: Unify allocation of low memory trampolines H. Peter Anvin
2011-02-18 5:19 ` [tip:x86/trampoline] x86, trampoline: Common infrastructure for " tip-bot for H. Peter Anvin
2011-02-18 12:16 ` Brian Gerst
2011-02-19 1:25 ` [tip:x86/trampoline] x86-64, trampoline: Remove unused variable tip-bot for H. Peter Anvin
2011-08-23 19:05 ` [tip:x86/trampoline] x86, trampoline: Common infrastructure for low memory trampolines Tony Luck
2011-08-23 19:12 ` H. Peter Anvin
2011-08-23 20:26 ` [PATCH] x86: remove some noise from boot log when starting cpus Luck, Tony
2012-02-20 16:08 ` Borislav Petkov
2012-02-22 10:33 ` Ingo Molnar
2012-02-22 10:57 ` Borislav Petkov
2012-02-22 11:29 ` Ingo Molnar
2012-02-22 18:06 ` [PATCH/resubmit] x86: Remove " Luck, Tony
2012-02-22 18:25 ` [tip:x86/cpu] " tip-bot for Luck, Tony
2012-02-22 20:34 ` [tip:x86/debug] x86/debug: Remove ancient debugging " tip-bot for Luck, Tony
2011-02-18 5:19 ` [tip:x86/trampoline] x86, trampoline: Use the unified trampoline setup for ACPI wakeup tip-bot for H. Peter Anvin
2011-03-09 22:41 ` matthieu castet
2011-03-10 0:07 ` Rafael J. Wysocki
2011-02-18 5:19 ` [tip:x86/trampoline] x86: Make the GDT_ENTRY() macro in <asm/segment.h> safe for assembly tip-bot for H. Peter Anvin
2011-02-18 5:20 ` [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file tip-bot for H. Peter Anvin
2011-02-18 12:31 ` Brian Gerst
2011-02-18 17:42 ` H. Peter Anvin [this message]
2011-02-19 1:25 ` [tip:x86/trampoline] x86, reboot: Fix the use of passed arguments in 32-bit BIOS reboot tip-bot for H. Peter Anvin
2011-04-29 15:16 ` [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file Alexey Zaytsev
2011-04-29 16:09 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5EAF76.6080301@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=brgerst@gmail.com \
--cc=castet.matthieu@free.fr \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).