From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [PATCH 1/4] x86, numa: Do not scan two times for setup_node_bootmem()
Date: Fri, 18 Feb 2011 10:59:03 -0800 [thread overview]
Message-ID: <4D5EC177.7030101@kernel.org> (raw)
In-Reply-To: <4D5EC05A.60103@kernel.org>
We don't need to scan two times for setup_node_bootmem()
because We are using mapped memblock for node_data finding already.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/mm/numa_64.c | 31 +++++++++++++------------------
1 file changed, 13 insertions(+), 18 deletions(-)
Index: linux-2.6/arch/x86/mm/numa_64.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/numa_64.c
+++ linux-2.6/arch/x86/mm/numa_64.c
@@ -480,7 +480,7 @@ static bool __init numa_meminfo_cover_me
static int __init numa_register_memblks(struct numa_meminfo *mi)
{
- int i, j, nid;
+ int i, nid;
/* Account for nodes with cpus and no memory */
node_possible_map = numa_nodes_parsed;
@@ -507,27 +507,22 @@ static int __init numa_register_memblks(
init_memory_mapping_high();
/*
- * Finally register nodes. Do it twice in case setup_node_bootmem
- * missed one due to missing bootmem.
+ * Do not do that twice, not needed!
+ * We are using mapped memblock directly for node data
*/
- for (i = 0; i < 2; i++) {
- for_each_node_mask(nid, node_possible_map) {
- u64 start = (u64)max_pfn << PAGE_SHIFT;
- u64 end = 0;
+ for_each_node_mask(nid, node_possible_map) {
+ u64 start = (u64)max_pfn << PAGE_SHIFT;
+ u64 end = 0;
- if (node_online(nid))
+ for (i = 0; i < mi->nr_blks; i++) {
+ if (nid != mi->blk[i].nid)
continue;
-
- for (j = 0; j < mi->nr_blks; j++) {
- if (nid != mi->blk[j].nid)
- continue;
- start = min(mi->blk[j].start, start);
- end = max(mi->blk[j].end, end);
- }
-
- if (start < end)
- setup_node_bootmem(nid, start, end);
+ start = min(mi->blk[i].start, start);
+ end = max(mi->blk[i].end, end);
}
+
+ if (start < end)
+ setup_node_bootmem(nid, start, end);
}
return 0;
next parent reply other threads:[~2011-02-18 19:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D5EC05A.60103@kernel.org>
2011-02-18 18:59 ` Yinghai Lu [this message]
2011-02-20 4:03 ` [PATCH 1/4] x86, numa: Do not scan two times for setup_node_bootmem() David Rientjes
2011-02-21 10:20 ` [PATCH] x86-64, NUMA: " Tejun Heo
2011-02-18 18:59 ` [PATCH 2/4] x86, numa: Do not adjust start/end for early_node_mem() Yinghai Lu
2011-02-20 4:03 ` David Rientjes
2011-02-20 4:17 ` Yinghai Lu
2011-02-21 9:43 ` Tejun Heo
2011-02-21 10:44 ` Tejun Heo
2011-02-21 20:28 ` Yinghai Lu
2011-02-22 10:36 ` Tejun Heo
2011-02-22 10:39 ` Tejun Heo
2011-02-21 17:21 ` Yinghai Lu
2011-02-22 0:27 ` David Rientjes
2011-02-18 18:59 ` [PATCH 3/4] x86, numa: cleanup x86_acpi_numa_init() Yinghai Lu
2011-02-20 4:03 ` David Rientjes
2011-02-21 9:46 ` Tejun Heo
2011-02-18 18:59 ` [PATCH 4/4] x86, numa: seperate alloc_numa_distance from numa_reset_distance Yinghai Lu
2011-02-20 4:03 ` David Rientjes
2011-02-21 10:48 ` Tejun Heo
2011-02-21 17:36 ` Yinghai Lu
2011-02-22 10:23 ` [PATCH] x86-64, NUMA: Seperate out numa_alloc_distance() from numa_set_distance() Tejun Heo
2011-02-22 10:30 ` Ingo Molnar
2011-02-22 10:32 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5EC177.7030101@kernel.org \
--to=yinghai@kernel.org \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).