From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Cai, Cliff" <Cliff.Cai@analog.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Drivers <Drivers@analog.com>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [Device-drivers-devel] [PATCH] IIO driver for Analog Devices Digital Output Gyroscope ADXRS450
Date: Tue, 22 Feb 2011 14:01:22 +0000 [thread overview]
Message-ID: <4D63C1B2.1050507@cam.ac.uk> (raw)
In-Reply-To: <4D5914A8.9030809@analog.com>
On 02/14/11 11:40, Michael Hennerich wrote:
> Hi Cliff,
>
> Exposing every single register to user space is not an acceptable driver.
> Ideally a user of this driver doesn't need to read the datasheet, only
> the IIO ABI Documentation.
> This driver can also benefit from triggered sampling/ring buffer support.
At some point.... I wouldn't necessarily advocate this for an initial merge. doing
it in two steps can make for bite sized reviews which definitely have their
advantages!
Given Michael has done a thorough review (thanks) I'll leave looking at this until
you've addressed his comments. Please be careful to avoid dead email addresses (test@analog.com)
Thanks,
Jonathan
prev parent reply other threads:[~2011-02-22 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 9:47 [PATCH] IIO driver for Analog Devices Digital Output Gyroscope ADXRS450 test
2011-02-14 11:40 ` [Device-drivers-devel] " Michael Hennerich
2011-02-22 14:01 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D63C1B2.1050507@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Cliff.Cai@analog.com \
--cc=Drivers@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox