From: Mike Waychison <mikew@google.com>
To: Greg KH <greg@kroah.com>
Cc: Olof Johansson <olofj@chromium.org>,
Andi Kleen <andi@firstfloor.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Robert Lippert <rlippert@google.com>,
Jon Mayer <jonmayer@google.com>,
Duncan Laurie <dlaurie@google.com>,
Aaron Durbin <adurbin@google.com>,
linux-kernel@vger.kernel.org, Tim Hockin <thockin@google.com>,
David Hendrix <dhendrix@chromium.org>,
linux-api@vger.kernel.org, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v1 2/5] firmware: Basic dmi-sysfs support
Date: Tue, 22 Feb 2011 15:31:02 -0800 [thread overview]
Message-ID: <4D644736.9050109@google.com> (raw)
In-Reply-To: <20110217215608.GA2451@kroah.com>
On 02/17/11 13:56, Greg KH wrote:
> Overall, this looks great, just a few minor comments below:
>
> On Thu, Feb 17, 2011 at 01:28:05PM -0800, Mike Waychison wrote:
>> +config DMI_SYSFS
>> + tristate "DMI table support in sysfs"
>> + depends on SYSFS&& DMI
>> + default X86
>
> Huh? Default should be 'N' for any new feature, unless it keeps your
> machine from booting.
>
> I think you want this option to depend on X86 though, right?
Looks to be supported on ia64 as well, though I don't have any hardware
to test this code on for that arch. Tony: I think this DMI exporting
code should just work on ia64 as all it is using is dmi_walk() and
parsing the entries as returned as dmi_headers in the callback. Does
this sound sane to you?
>
>> + help
>> + Say Y or M here to enable the exporting of the raw DMI table
>> + data via sysfs. This is useful for consuming the data without
>> + requiring any access to /dev/mem at all. Tables are found
>> + under /sys/firmware/dmi when this option is enabled and
>> + loaded.
>
> I just realized (due to other work I'm doing on a laptop) that we have a
> bunch of entries today in /sys/class/dmi/id which is a pointer to the
> dmi "device".
>
> Now I think this really is different (these are the raw DMI tables), but
> this doesn't have anything to do with that code, right?
Ya, it is similar, though the primary goal I have is to export these raw
bytes. The data comes from the same place, however the dmi-id code is
just exporting the in-kernel copies of the strings parsed at boot.
These could probably be better exported under
/sys/firmware/dmi/entries/[0123]-*/ files imo.
Mike Waychison
next prev parent reply other threads:[~2011-02-22 23:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 21:27 [PATCH v1 0/5] Exporting DMI entries via syfs Mike Waychison
2011-02-17 21:28 ` [PATCH v1 1/5] firmware: Add DMI entry types to the headers Mike Waychison
2011-02-17 21:28 ` [PATCH v1 2/5] firmware: Basic dmi-sysfs support Mike Waychison
2011-02-17 21:42 ` Tim Hockin
2011-02-17 21:56 ` Greg KH
2011-02-22 23:31 ` Mike Waychison [this message]
2011-02-23 0:07 ` Luck, Tony
2011-02-22 23:49 ` Rob Lippert
2011-02-22 23:58 ` Mike Waychison
2011-02-17 21:28 ` [PATCH v1 3/5] firmware: Break out system_event_log in dmi-sysfs Mike Waychison
2011-02-17 21:28 ` [PATCH v1 4/5] firmware: Expose DMI type 15 System Event Log Mike Waychison
2011-02-17 21:28 ` [PATCH v1 5/5] firmware: Add documentation for /sys/firmware/dmi Mike Waychison
2011-02-17 21:50 ` Tim Hockin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D644736.9050109@google.com \
--to=mikew@google.com \
--cc=adurbin@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=dhendrix@chromium.org \
--cc=dlaurie@google.com \
--cc=greg@kroah.com \
--cc=jonmayer@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rlippert@google.com \
--cc=thockin@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox