* [PATCH 0/2] staging: vme: fix issues in vme_register_bridge
@ 2011-02-23 13:25 Manohar Vanga
2011-02-23 13:25 ` [PATCH 1/2] staging: vme: remove unreachable code Manohar Vanga
2011-02-23 13:25 ` [PATCH 2/2] staging: vme: fix loop condition Manohar Vanga
0 siblings, 2 replies; 7+ messages in thread
From: Manohar Vanga @ 2011-02-23 13:25 UTC (permalink / raw)
To: martyn.welch; +Cc: gregkh, wfp5p, cota, devel, linux-kernel, Manohar Vanga
This patchset fixes two issues I found in vme_register_bridge.
The first gets rid of some unreachable code and the second one fixes
a bug that could potentially lead to an infinite loop in the event
that device_register fails.
Please skip the previous patchset I sent and reacknowledge these.
Apologies for the noise pollution.
Thanks,
Manohar Vanga
Manohar Vanga (2):
staging: vme: remove unreachable code
staging: vme: fix loop condition
drivers/staging/vme/vme.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] staging: vme: remove unreachable code
2011-02-23 13:25 [PATCH 0/2] staging: vme: fix issues in vme_register_bridge Manohar Vanga
@ 2011-02-23 13:25 ` Manohar Vanga
2011-02-23 13:56 ` Dan Carpenter
2011-02-23 17:00 ` Martyn Welch
2011-02-23 13:25 ` [PATCH 2/2] staging: vme: fix loop condition Manohar Vanga
1 sibling, 2 replies; 7+ messages in thread
From: Manohar Vanga @ 2011-02-23 13:25 UTC (permalink / raw)
To: martyn.welch; +Cc: gregkh, wfp5p, cota, devel, linux-kernel, Manohar Vanga
Removed some unreachable code from vme_register_bridge
Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
---
drivers/staging/vme/vme.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
index d9fc864..88bf455 100644
--- a/drivers/staging/vme/vme.c
+++ b/drivers/staging/vme/vme.c
@@ -1363,7 +1363,6 @@ int vme_register_bridge(struct vme_bridge *bridge)
return retval;
- i = VME_SLOTS_MAX;
err_reg:
while (i > -1) {
dev = &bridge->dev[i];
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] staging: vme: remove unreachable code
2011-02-23 13:25 ` [PATCH 1/2] staging: vme: remove unreachable code Manohar Vanga
@ 2011-02-23 13:56 ` Dan Carpenter
2011-02-23 17:00 ` Martyn Welch
1 sibling, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2011-02-23 13:56 UTC (permalink / raw)
To: Manohar Vanga; +Cc: martyn.welch, devel, gregkh, cota, linux-kernel
On Wed, Feb 23, 2011 at 02:25:27PM +0100, Manohar Vanga wrote:
> Removed some unreachable code from vme_register_bridge
>
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
Acked-by: Dan Carpenter <error27@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] staging: vme: remove unreachable code
2011-02-23 13:25 ` [PATCH 1/2] staging: vme: remove unreachable code Manohar Vanga
2011-02-23 13:56 ` Dan Carpenter
@ 2011-02-23 17:00 ` Martyn Welch
1 sibling, 0 replies; 7+ messages in thread
From: Martyn Welch @ 2011-02-23 17:00 UTC (permalink / raw)
To: Manohar Vanga; +Cc: gregkh, wfp5p, cota, devel, linux-kernel
On 23/02/11 13:25, Manohar Vanga wrote:
> Removed some unreachable code from vme_register_bridge
>
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/vme.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index d9fc864..88bf455 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1363,7 +1363,6 @@ int vme_register_bridge(struct vme_bridge *bridge)
>
> return retval;
>
> - i = VME_SLOTS_MAX;
> err_reg:
> while (i > -1) {
> dev = &bridge->dev[i];
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] staging: vme: fix loop condition
2011-02-23 13:25 [PATCH 0/2] staging: vme: fix issues in vme_register_bridge Manohar Vanga
2011-02-23 13:25 ` [PATCH 1/2] staging: vme: remove unreachable code Manohar Vanga
@ 2011-02-23 13:25 ` Manohar Vanga
2011-02-23 13:57 ` Dan Carpenter
2011-02-23 17:01 ` Martyn Welch
1 sibling, 2 replies; 7+ messages in thread
From: Manohar Vanga @ 2011-02-23 13:25 UTC (permalink / raw)
To: martyn.welch; +Cc: gregkh, wfp5p, cota, devel, linux-kernel, Manohar Vanga
Fix loop condition in vme_register_bridge that results in an infinite
loop in the event that device_register fails.
Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
---
drivers/staging/vme/vme.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
index 88bf455..c1ec230 100644
--- a/drivers/staging/vme/vme.c
+++ b/drivers/staging/vme/vme.c
@@ -1364,7 +1364,7 @@ int vme_register_bridge(struct vme_bridge *bridge)
return retval;
err_reg:
- while (i > -1) {
+ while (--i >= 0) {
dev = &bridge->dev[i];
device_unregister(dev);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] staging: vme: fix loop condition
2011-02-23 13:25 ` [PATCH 2/2] staging: vme: fix loop condition Manohar Vanga
@ 2011-02-23 13:57 ` Dan Carpenter
2011-02-23 17:01 ` Martyn Welch
1 sibling, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2011-02-23 13:57 UTC (permalink / raw)
To: Manohar Vanga; +Cc: martyn.welch, devel, gregkh, cota, linux-kernel
On Wed, Feb 23, 2011 at 02:25:28PM +0100, Manohar Vanga wrote:
> Fix loop condition in vme_register_bridge that results in an infinite
> loop in the event that device_register fails.
>
Acked-by: Dan Carpenter <error27@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] staging: vme: fix loop condition
2011-02-23 13:25 ` [PATCH 2/2] staging: vme: fix loop condition Manohar Vanga
2011-02-23 13:57 ` Dan Carpenter
@ 2011-02-23 17:01 ` Martyn Welch
1 sibling, 0 replies; 7+ messages in thread
From: Martyn Welch @ 2011-02-23 17:01 UTC (permalink / raw)
To: Manohar Vanga; +Cc: gregkh, wfp5p, cota, devel, linux-kernel
On 23/02/11 13:25, Manohar Vanga wrote:
> Fix loop condition in vme_register_bridge that results in an infinite
> loop in the event that device_register fails.
>
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/vme.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 88bf455..c1ec230 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1364,7 +1364,7 @@ int vme_register_bridge(struct vme_bridge *bridge)
> return retval;
>
> err_reg:
> - while (i > -1) {
> + while (--i >= 0) {
> dev = &bridge->dev[i];
> device_unregister(dev);
> }
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-23 17:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 13:25 [PATCH 0/2] staging: vme: fix issues in vme_register_bridge Manohar Vanga
2011-02-23 13:25 ` [PATCH 1/2] staging: vme: remove unreachable code Manohar Vanga
2011-02-23 13:56 ` Dan Carpenter
2011-02-23 17:00 ` Martyn Welch
2011-02-23 13:25 ` [PATCH 2/2] staging: vme: fix loop condition Manohar Vanga
2011-02-23 13:57 ` Dan Carpenter
2011-02-23 17:01 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox