public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>
Subject: [PATCH] ia64/mca: Fix cast from integer to pointer warning
Date: Thu, 24 Feb 2011 17:23:09 -0500	[thread overview]
Message-ID: <4D66DA4D.4020609@suse.com> (raw)

 ia64_mca_cpu_init has a void *data local variable that is assigned
 the value from either __get_free_pages() or mca_bootmem(). The problem
 is that __get_free_pages returns an unsigned long and mca_bootmem, via
 alloc_bootmem(), returns a void *. format_mca_init_stack takes the void *,
 and it's also used with __pa(), but that casts it to long anyway.

 This results in the following build warning:

 arch/ia64/kernel/mca.c:1898: warning: assignment makes pointer from
 integer without a cast

 This patch casts the return of __get_free_pages to a void * to avoid
 the warning.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 arch/ia64/kernel/mca.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -1859,7 +1859,8 @@ ia64_mca_cpu_init(void *cpu_data)
 			data = mca_bootmem();
 			first_time = 0;
 		} else
-			data = __get_free_pages(GFP_KERNEL, get_order(sz));
+			data = (void *)__get_free_pages(GFP_KERNEL,
+							get_order(sz));
 		if (!data)
 			panic("Could not allocate MCA memory for cpu %d\n",
 					cpu);
-- 
Jeff Mahoney
SUSE Labs

                 reply	other threads:[~2011-02-24 22:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D66DA4D.4020609@suse.com \
    --to=jeffm@suse.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox