public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* OF IOAPIC bindings compile error
@ 2011-02-25 15:35 Daniel Drake
  2011-02-25 15:38 ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Drake @ 2011-02-25 15:35 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-kernel, devicetree-discuss, Andres Salomon, tglx

Hi,

Testing linux-2.6-x86.git, I encountered a compile error which seems
to caused by the following commit with X86_IO_APIC=n:

commit bcc7c1244fcfd852b9f4590935491057e1cab9dd
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date:   Tue Feb 22 21:07:44 2011 +0100

    x86: ioapic: Add OF bindings for IO_APIC

Error is:
arch/x86/kernel/devicetree.c: In function ‘x86_dtb_find_config’:
arch/x86/kernel/devicetree.c:288:3: error: lvalue required as left
operand of assignment

It can be fixed by inserting #ifdef CONFIG_X86_IO_APIC inside
x86_dtb_find_config, but I'm not sure if this is the correct approach.

.config file in question:
http://dev.laptop.org/~dsd/20110225/ioioapic-problem-config.txt

Daniel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: OF IOAPIC bindings compile error
  2011-02-25 15:35 OF IOAPIC bindings compile error Daniel Drake
@ 2011-02-25 15:38 ` Sebastian Andrzej Siewior
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2011-02-25 15:38 UTC (permalink / raw)
  To: Daniel Drake; +Cc: linux-kernel, devicetree-discuss, Andres Salomon, tglx

Daniel Drake wrote:
> Hi,
Hi,

> 
> Testing linux-2.6-x86.git, I encountered a compile error which seems
> to caused by the following commit with X86_IO_APIC=n:
> 
> commit bcc7c1244fcfd852b9f4590935491057e1cab9dd
> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Date:   Tue Feb 22 21:07:44 2011 +0100
> 
>     x86: ioapic: Add OF bindings for IO_APIC

Please check:
Commit-ID:  a906fdaacca49917d83e5032dfc31f694249ad10
Gitweb:     http://git.kernel.org/tip/a906fdaacca49917d83e5032dfc31f694249ad10
x86: dt: Cleanup local apic setup

this fixes it.

> Daniel

Sebastian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-25 15:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-25 15:35 OF IOAPIC bindings compile error Daniel Drake
2011-02-25 15:38 ` Sebastian Andrzej Siewior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox