public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: preining@logic.at,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
	"debora@linux.vnet.ibm.com" <debora@linux.vnet.ibm.com>
Subject: Re: [PATCH] tpm_tis: Re-enable interrupts upon resume
Date: Sat, 26 Feb 2011 12:46:19 +0100	[thread overview]
Message-ID: <4D68E80B.90001@gmail.com> (raw)
In-Reply-To: <1298404199.25819.15.camel@d941e-10>

On 02/22/2011 08:49 PM, Stefan Berger wrote:
> Below patch applies to the tip of the git tree.
> 
> This patch makes sure that if the TPM TIS interface is run in interrupt
> mode (rather than polling mode) that the interrupts are enabled in the
> TPM's interrupt enable register which may either have been cleared by
> the TPM's TIS loosing its state during device sleep in ACPI S3 (suspend)
> or by the BIOS, which upon resume sends a TPM_Startup() command to the
> TPM, and may run the TPM in polling mode and leave the TIS interrupts
> disabled once it transfers control to the OS again.
> 
> Problem is, I don't currently have a machine running the TPM in
> interrupt mode. I found this through a self-built TPM device model for
> Qemu and SeaBIOS patches, where this does resolve a problem upon resume.
> 
> You may want to check if your TPM runs with interrupts by doing
> 
> cat /proc/interrupts | grep -i tpm

No, this is empty output.

regards,
-- 
js

  reply	other threads:[~2011-02-26 11:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 19:49 [PATCH] tpm_tis: Re-enable interrupts upon resume Stefan Berger
2011-02-26 11:46 ` Jiri Slaby [this message]
2011-02-26 13:50   ` Stefan Berger
2011-03-01  7:45 ` [PATCH v2] " Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D68E80B.90001@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=debora@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=preining@logic.at \
    --cc=srajiv@linux.vnet.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox