From: Jiri Slaby <jirislaby@gmail.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: preining@logic.at,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
"debora@linux.vnet.ibm.com" <debora@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM
Date: Sat, 26 Feb 2011 14:49:45 +0100 [thread overview]
Message-ID: <4D6904F9.7080604@gmail.com> (raw)
In-Reply-To: <4D6904CB.9020309@linux.vnet.ibm.com>
On 02/26/2011 02:48 PM, Stefan Berger wrote:
> On 02/26/2011 06:45 AM, Jiri Slaby wrote:
>> On 02/22/2011 08:41 PM, Stefan Berger wrote:
>>> Below patch applies to the tip of the git tree.
>>>
>>> v2:
>>> - adjusting all timeouts for TPM devices reporting too low timeout
>>> numbers
>>> - also displaying in sysfs whether the timeouts are 'original' or
>>> 'adjusted'
>>>
>>> The current TPM TIS driver in git discards the timeout values returned
>>> from the TPM. The check of the response packet needs to consider that
>>> the return_code field is 0 on success and the size of the expected
>>> packet is equivalent to the header size + u32 length indicator for the
>>> TPM_GetCapability() result + 3 timeout indicators of type u32.
>>>
>>> Since some TPMs seem to return timeouts in msec rather than usec,
>>> I am now adjusting all the timeouts rather than just the one for short
>>> durations.
>>>
>>> I am also adding a sysfs entry 'timeouts' showing the timeouts that are
>>> being used.
>> It works:
> 'It' means also 'suspend' works?
Yes.
regards,
--
js
next prev parent reply other threads:[~2011-02-26 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 19:41 [PATCH v2] tpm_tis: Use timeouts returned from TPM Stefan Berger
2011-02-26 11:45 ` Jiri Slaby
2011-02-26 13:48 ` Stefan Berger
2011-02-26 13:49 ` Jiri Slaby [this message]
2011-02-26 14:03 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6904F9.7080604@gmail.com \
--to=jirislaby@gmail.com \
--cc=debora@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=preining@logic.at \
--cc=srajiv@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox