Re: [PATCH -tip 1/2 resend] x86, nmi: Define a name for NMI control port

Don Zickus
2011-03-02T19:35:43Z

On Wed, Mar 02, 2011 at 06:32:30PM +0300, Cyrill Gorcunov wrote:
> Also add a comment anout why we need in-out operations.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>
> Ingo I hope this time I've resolved MUA space injection.
>
> arch/x86/include/asm/mach_traps.h | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> Index: linux-2.6.git/arch/x86/include/asm/mach_traps.h
> =====================================================================
> --- linux-2.6.git.orig/arch/x86/include/asm/mach_traps.h
> +++ linux-2.6.git/arch/x86/include/asm/mach_traps.h
> @@ -8,6 +8,7 @@
> #include <asm/mc146818rtc.h>
>
> #define NMI_REASON_PORT 0x61
> +#define NMI_ENABLE_PORT 0x70 /* Real-Time Clock Address Register as well */
>
> #define NMI_REASON_SERR 0x80
> #define NMI_REASON_IOCHK 0x40
> @@ -30,12 +31,19 @@ static inline void reassert_nmi(void)
> old_reg = current_lock_cmos_reg();
> else
> lock_cmos(0); /* register doesn't matter here */
> - outb(0x8f, 0x70);
> - inb(0x71); /* dummy */

I was wondering if 0x71 should get a name change too. Then again I can't
find the Intel doc that tells me what 0x70 is either (I remember seeing it
somewhere).

Cheers,
Don