Re: [PATCH -tip 2/2 resend] x86, traps: Drop nmi_reason_lock until it is really needed

[Cyrill Gorcunov <gorcunov@openvz.org>]

On 03/02/2011 06:46 PM, Ingo Molnar wrote:
> 
> * Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> 
>> At moment we have only BSP apic configured to listen
>> for external NMIs. So there is no reason for additional
>> spinlock since only BSP will receive them.
>>
>> Though we still have UV chips which do enable external NMIs
>> on all cpus, but since an approach to allow retrieving
>> NMI reason on BSP only was working pretty fine before --
>> I assume it still remains valid.
> 
> I'm not sure I get the point here: we might get NMIs on non-BSP on UV
> systems ... so we want to remove the spinlock?
> 
> If UV systems can get NMIs on any CPU then the lock is needed.
> 
> It might have worked before - but UV systems are rare and relatively
> new - plus the race window is small, so it might not have been triggered
> in practice.

  Well, it is incomplete anyway. As far as I can tell even ordering such
NMIs with spinlock would not make situation better 'cause other cpu might
obtain unknown nmi (ie two or more cpu's gets NMI then handing started on
first found that it was say MCE error, handle it, unlock spinlock and then
the second cpu gets this nmi (the reason for which was already handled by
first cpu) and sees unknown NMI. So this lock might simply hiding a bug.
Of course I might be missing something.

> 
>> Also it's worth to mention that an initial idea of all this
>> NMI code-path changes was to make BSP hot-unpluggable but
>> until all other parts of kernel is prepared for it (which
>> might consume quite a time to implement) I believe we should
>> not lock/unlock for nothing.
> 
> That would be another argument in favor of keeping the lock, right?

Yes, but I think this lock should be the last thing which is introduced,
after all other parts of kernel are ready for bsp unplug.

> 
> Thanks,
> 
> 	Ingo


-- 
    Cyrill