public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jack Stone <jwjstone@fastmail.fm>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, Al Cho <acho@novell.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: keucr: use kernel byteorder functions
Date: Thu, 03 Mar 2011 07:58:59 +0000	[thread overview]
Message-ID: <4D6F4A43.5050903@fastmail.fm> (raw)
In-Reply-To: <1299109694-28758-2-git-send-email-j.neuschaefer@gmx.net>

> @@ -455,10 +457,10 @@ int MS_LibProcessBootBlock(struct us_data *us, WORD PhyBlock, BYTE *PageData)
>  			}
>  
>  			idi = &((MemStickBootBlockCIS_IDI *)(PageBuffer + (EntryOffset % MS_BYTES_PER_PAGE)))->idi.idi;
> -			if (LittleEndianWORD(idi->wIDIgeneralConfiguration) != MS_IDI_GENERAL_CONF)
> +			if (le16_to_cpu(idi->wIDIgeneralConfiguration) != MS_IDI_GENERAL_CONF)
>  				goto exit;
>  
> -			us->MS_Lib.BytesPerSector = LittleEndianWORD(idi->wIDIbytesPerSector);
> +			us->MS_Lib.BytesPerSector = be16_to_cpu(idi->wIDIbytesPerSector);

Shouldn't this be le16_to_cpu?

>  			if (us->MS_Lib.BytesPerSector != MS_BYTES_PER_PAGE)
>  				goto exit;
>  		}

Thanks,

Jack

  reply	other threads:[~2011-03-03  7:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 23:48 [PATCH 1/2] staging: keucr: remove unused typedef VOID Jonathan Neuschäfer
2011-03-02 23:48 ` [PATCH 2/2] staging: keucr: use kernel byteorder functions Jonathan Neuschäfer
2011-03-03  7:58   ` Jack Stone [this message]
2011-03-03 11:32     ` Jonathan Neuschäfer
2011-03-03 11:38       ` [PATCH v2] " Jonathan Neuschäfer
2011-03-03 11:51         ` Jack Stone
2011-03-03 13:25           ` [PATCH v3 1/2] staging: keucr: remove unused typedef VOID Jonathan Neuschäfer
2011-03-03 13:25             ` [PATCH v3 2/2] staging: keucr: use kernel byteorder functions Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6F4A43.5050903@fastmail.fm \
    --to=jwjstone@fastmail.fm \
    --cc=acho@novell.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=j.neuschaefer@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox