From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Henrik Kretzschmar <henne@nachtwindheim.de>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] x86: fix section of a disable_apic_timer
Date: Fri, 04 Mar 2011 00:18:41 +0300 [thread overview]
Message-ID: <4D7005B1.4020008@gmail.com> (raw)
In-Reply-To: <1299182701-8591-7-git-send-email-henne@nachtwindheim.de>
On 03/03/2011 11:05 PM, Henrik Kretzschmar wrote:
> This variable placed better into section .init.data,
> since its only accessed by __init code.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> ---
> arch/x86/kernel/apic/apic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 64efb2d..dab58b6 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -163,7 +163,7 @@ early_param("nox2apic", setup_nox2apic);
> unsigned long mp_lapic_addr;
> int disable_apic;
> /* Disable local APIC timer from the kernel commandline or via dmi quirk */
> -static int disable_apic_timer __cpuinitdata;
> +static int disable_apic_timer __initdata = 0;
> /* Local APIC timer works in C2 */
> int local_apic_timer_c2_ok;
> EXPORT_SYMBOL_GPL(local_apic_timer_c2_ok);
Good to me, though I don't get why we need 0 here.
--
Cyrill
next prev parent reply other threads:[~2011-03-03 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 20:04 [PATCH 1/7] x86: remove superflous goal definition of tsc_sync Henrik Kretzschmar
2011-03-03 20:04 ` [PATCH 2/7] x86: make some apic symbols init Henrik Kretzschmar
2011-03-03 21:19 ` Cyrill Gorcunov
2011-03-04 9:09 ` Henrik Kretzschmar
2011-03-03 20:04 ` [PATCH 3/7] x86: make apic_disable() static and init Henrik Kretzschmar
2011-03-03 20:45 ` Cyrill Gorcunov
2011-03-03 20:04 ` [PATCH 4/7] x86: remove enable_NMI_through_LVT0() entirely Henrik Kretzschmar
2011-03-03 20:54 ` Cyrill Gorcunov
2011-03-03 20:04 ` [PATCH 5/7] x86: remove ancient crufty prototype Henrik Kretzschmar
2011-03-03 21:03 ` Cyrill Gorcunov
2011-03-03 20:05 ` [PATCH 6/7] x86: remove unneeded prototypes Henrik Kretzschmar
2011-03-03 21:13 ` Cyrill Gorcunov
2011-03-03 20:05 ` [PATCH 7/7] x86: fix section of a disable_apic_timer Henrik Kretzschmar
2011-03-03 21:18 ` Cyrill Gorcunov [this message]
2011-03-04 9:06 ` Henrik Kretzschmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7005B1.4020008@gmail.com \
--to=gorcunov@gmail.com \
--cc=henne@nachtwindheim.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox