Re: [PATCH] x86, numa: move bootnode definition into srat_64.c

[Yinghai Lu <yinghai@kernel.org>]

On 03/03/2011 12:52 PM, David Rientjes wrote:
> On Wed, 2 Mar 2011, Yinghai Lu wrote:
> 
>> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c
>> index 8e9d339..7e5d0e9 100644
>> --- a/arch/x86/mm/srat_64.c
>> +++ b/arch/x86/mm/srat_64.c
>> @@ -26,6 +26,11 @@
>>  
>>  int acpi_numa __initdata;
>>  
>> +struct bootnode {
>> +	u64 start;
>> +	u64 end;
>> +};
>> +
>>  static struct bootnode nodes_add[MAX_NUMNODES];
>>  
>>  static __init int setup_node(int pxm)
> 
> Can we get rid of struct bootnode instead and simply reuse 
> struct numa_memblk?  The latter isn't actually tied to memblock and is a 
> generic representation of a node id and address range.

Yes, could be don later esp if the hotplug mem code would support 
more than one block add per node.

Yinghai