* Re: mmotm 2011-03-02-16-52 uploaded
2011-03-03 0:52 mmotm 2011-03-02-16-52 uploaded akpm
@ 2011-03-03 2:05 ` Stephen Rothwell
2011-03-03 2:17 ` Andrew Morton
2011-03-03 8:26 ` Sedat Dilek
` (3 subsequent siblings)
4 siblings, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2011-03-03 2:05 UTC (permalink / raw)
To: akpm; +Cc: mm-commits, linux-kernel, linux-mm, linux-fsdevel
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
Hi Andrew,
On Wed, 02 Mar 2011 16:52:55 -0800 akpm@linux-foundation.org wrote:
>
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
If you create your linux-next.patch using kapm-start..kapm-end in the
linux-next tree, you will save about 8000+ lines of patch and you won't
need "next-remove-localversion.patch" any more. I am keeping those
references up to date each day.
BTW, To keep "git am" happy:
diff --git a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
index e081c43..42c45fc 100644
--- a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
+++ b/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
@@ -1,3 +1,4 @@
+From: Johannes Weiner <hannes@cmpxchg.org>
Keep the underscore-version of the charge cancelling function which took a
page count, rather than silently changing the semantics of the
Cheers,
Stephen Rothwell
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: mmotm 2011-03-02-16-52 uploaded
2011-03-03 2:05 ` Stephen Rothwell
@ 2011-03-03 2:17 ` Andrew Morton
2011-03-03 2:30 ` Stephen Rothwell
0 siblings, 1 reply; 20+ messages in thread
From: Andrew Morton @ 2011-03-03 2:17 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-kernel, linux-mm, linux-fsdevel
On Thu, 3 Mar 2011 13:05:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> On Wed, 02 Mar 2011 16:52:55 -0800 akpm@linux-foundation.org wrote:
> >
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> If you create your linux-next.patch using kapm-start..kapm-end in the
> linux-next tree, you will save about 8000+ lines of patch and you won't
> need "next-remove-localversion.patch" any more. I am keeping those
> references up to date each day.
What's in the 8000 lines?
> BTW, To keep "git am" happy:
>
> diff --git a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> index e081c43..42c45fc 100644
> --- a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> +++ b/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> @@ -1,3 +1,4 @@
> +From: Johannes Weiner <hannes@cmpxchg.org>
>
> Keep the underscore-version of the charge cancelling function which took a
> page count, rather than silently changing the semantics of the
>
Didn't understand that - why is git-am unhappy? Your sentence was
truncated.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: mmotm 2011-03-02-16-52 uploaded
2011-03-03 0:52 mmotm 2011-03-02-16-52 uploaded akpm
2011-03-03 2:05 ` Stephen Rothwell
@ 2011-03-03 8:26 ` Sedat Dilek
2011-03-03 20:50 ` mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files) Randy Dunlap
` (2 subsequent siblings)
4 siblings, 0 replies; 20+ messages in thread
From: Sedat Dilek @ 2011-03-03 8:26 UTC (permalink / raw)
To: akpm; +Cc: mm-commits, linux-kernel, linux-mm, linux-fsdevel
On Thu, Mar 3, 2011 at 1:52 AM, <akpm@linux-foundation.org> wrote:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.38-rc7:
>
[...]
> backlight-add-backlight-type.patch
> backlight-add-backlight-type-fix.patch
> backlight-add-backlight-type-fix-fix.patch
> i915-add-native-backlight-control.patch
> radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch
> radeon-expose-backlight-class-device-for-legacy-lvds-encoder-update.patch
> nouveau-change-the-backlight-parent-device-to-the-connector-not-the-pci-dev.patch
> acpi-tie-acpi-backlight-devices-to-pci-devices-if-possible.patch
> mbp_nvidia_bl-remove-dmi-dependency.patch
> mbp_nvidia_bl-check-that-the-backlight-control-functions.patch
> mbp_nvidia_bl-rename-to-apple_bl.patch
> backlight-apple_bl-depends-on-acpi.patch
> drivers-video-backlight-jornada720_c-make-needlessly-global-symbols-static.patch
[...]
And Sedat asked and is asking again for backlight (acpi + drm-2.6)
patches to go into 2.6.39...
There were 5 patches from Matthew Garrett...
IIRC you told me you took over backlight stuff from Richard Purdie
(hope I recall the name correctly).
First it is a bit hard for me to assign your changed patch names to
the original ones.
There are patches from your tree being recognised for linux-next...
What's up with the backlight ones?
Unfortunately, the last working linux-next (next-20110224) and the
patchset (I have maintained here) do not apply due to recent changes
in linux-next this week.
(Mostly the big patch 1-5 required adaptation to fit linux-next.)
And yes, I am a bit sick of it, so I kicked them for now.
I am not sure what is the ideal way to let these 5 patches (and more?)
go into linux-next (aka for-2.6.39)
But for the mentionned patchset platform-drivers-x86.git#linux-next
could be a good choice (it is automatically pulled into linux-next),
but this would mean Matthew has to do the work...
Anyway, I want to see this patchset in 2.6.39.
BTW, the below listed patchset was take #2 from Matthew.
I am sure take #3 will make me and others happy :-).
- Sedat -
$ ls -lR backlight-type/
backlight-type/:
insgesamt 80
-rw-r--r-- 1 sd sd 39541 23. Feb 09:19 1-5-Backlight-Add-backlight-type-v6.patch
-rw-r--r-- 1 sd sd 7389 15. Jan 15:18
2-5-i915-Add-native-backlight-control.patch
-rw-r--r-- 1 sd sd 7083 15. Jan 15:19
4-5-nouveau-Change-the-backlight-parent-device-to-the-connector-not-the-PCI-dev.patch
-rw-r--r-- 1 sd sd 2040 15. Jan 15:19
5-5-ACPI-Tie-ACPI-backlight-devices-to-PCI-devices-if-possible.patch
-rw-r--r-- 1 sd sd 13723 20. Jan 20:56
drm-radeon-kms-Expose-backlight-class-device-for-legacy-LVDS-encoder-v2.patch
drwxr-xr-x 2 sd sd 4096 8. Feb 17:39 orig
backlight-type/orig:
insgesamt 56
-rw-r--r-- 1 sd sd 39265 15. Jan 15:17 1-5-Backlight-Add-backlight-type.patch
-rw-r--r-- 1 sd sd 13905 15. Jan 15:18
3-5-radeon-Expose-backlight-class-device-for-legacy-LVDS-encoder.patch
-EOT-
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files)
2011-03-03 0:52 mmotm 2011-03-02-16-52 uploaded akpm
2011-03-03 2:05 ` Stephen Rothwell
2011-03-03 8:26 ` Sedat Dilek
@ 2011-03-03 20:50 ` Randy Dunlap
2011-03-03 21:06 ` Greg KH
2011-03-03 23:50 ` mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card Valdis.Kletnieks
2011-03-04 8:56 ` tun: Failed to create tun sysfs files [was: mmotm 2011-03-02-16-52 uploaded] Jiri Slaby
4 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2011-03-03 20:50 UTC (permalink / raw)
To: akpm, gregkh; +Cc: linux-kernel
On Wed, 02 Mar 2011 16:52:55 -0800 akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.38-rc7:
Who did the (incomplete) move of some tty drivers to staging? (in linux-next)
Please also move drivers/char/digi*.h
#include "digiPCI.h"
#include "digi1.h"
#include "digiFep1.h"
=>
drivers/staging/tty/epca.c:46:21: error: digiPCI.h: No such file or directory
drivers/staging/tty/epca.c:49:19: error: digi1.h: No such file or directory
drivers/staging/tty/epca.c:50:22: error: digiFep1.h: No such file or directory
causes over 100 build errors.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files)
2011-03-03 20:50 ` mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files) Randy Dunlap
@ 2011-03-03 21:06 ` Greg KH
0 siblings, 0 replies; 20+ messages in thread
From: Greg KH @ 2011-03-03 21:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: akpm, linux-kernel
On Thu, Mar 03, 2011 at 12:50:12PM -0800, Randy Dunlap wrote:
> On Wed, 02 Mar 2011 16:52:55 -0800 akpm@linux-foundation.org wrote:
>
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://zen-kernel.org/kernel/mmotm.git
> >
> > It contains the following patches against 2.6.38-rc7:
>
>
> Who did the (incomplete) move of some tty drivers to staging? (in linux-next)
That would be me :)
> Please also move drivers/char/digi*.h
>
> #include "digiPCI.h"
> #include "digi1.h"
> #include "digiFep1.h"
> =>
> drivers/staging/tty/epca.c:46:21: error: digiPCI.h: No such file or directory
> drivers/staging/tty/epca.c:49:19: error: digi1.h: No such file or directory
> drivers/staging/tty/epca.c:50:22: error: digiFep1.h: No such file or directory
>
> causes over 100 build errors.
Crap, sorry, thanks for pointing it out, will go fix this right now.
greg k-h
^ permalink raw reply [flat|nested] 20+ messages in thread
* mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card
2011-03-03 0:52 mmotm 2011-03-02-16-52 uploaded akpm
` (2 preceding siblings ...)
2011-03-03 20:50 ` mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files) Randy Dunlap
@ 2011-03-03 23:50 ` Valdis.Kletnieks
2011-03-04 0:05 ` Greg KH
2011-03-04 8:56 ` tun: Failed to create tun sysfs files [was: mmotm 2011-03-02-16-52 uploaded] Jiri Slaby
4 siblings, 1 reply; 20+ messages in thread
From: Valdis.Kletnieks @ 2011-03-03 23:50 UTC (permalink / raw)
To: akpm, Len Brown, Greg Kroah-Hartman; +Cc: linux-kernel, linux-acpi
[-- Attachment #1: Type: text/plain, Size: 3571 bytes --]
On Wed, 02 Mar 2011 16:52:55 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
Dell Latitude E6500, with an NVidia G98M (Quadro NVS 160M) graphics card.
Seen in my dmesg - it's had the 'Firmware Bug' message for roughly forever, but
apparently somewhere recently a warning crawled in. 2.6.38-rc5-next-20110222
did not throw the warning, jsut the firmware bug msg.
Hope somebody recognizes it, I won't be able to bisect this one for a bit (I
have 2 or 3 other things I have a bigger need to track down).
[ 0.784712] ACPI: Sleep Button [SBTN]
[ 0.816626] ------------[ cut here ]------------
[ 0.816633] WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0x88/0x9c()
[ 0.816635] Hardware name: Latitude E6500
[ 0.816637] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:01.0/0000:01:00.0/backlight/acpi_video0/device'
[ 0.816640] Modules linked in:
[ 0.816645] Pid: 1, comm: swapper Not tainted 2.6.38-rc7-mmotm0302 #2
[ 0.816647] Call Trace:
[ 0.816652] [<ffffffff8103899e>] ? warn_slowpath_common+0x7e/0x96
[ 0.816657] [<ffffffff81038a4a>] ? warn_slowpath_fmt+0x41/0x43
[ 0.816661] [<ffffffff8114d876>] ? sysfs_add_one+0x88/0x9c
[ 0.816665] [<ffffffff8114e06e>] ? sysfs_do_create_link+0x145/0x1d5
[ 0.816669] [<ffffffff8114e10c>] ? sysfs_create_link+0xe/0x10
[ 0.816674] [<ffffffff8126cef1>] ? acpi_video_device_find_cap+0x1f5/0x2de
[ 0.816678] [<ffffffff8126d196>] ? acpi_video_bus_get_one_device+0x1bc/0x250
[ 0.816682] [<ffffffff8126d3f8>] ? acpi_video_bus_add+0x1ce/0x36e
[ 0.816687] [<ffffffff8124983d>] ? acpi_device_probe+0x49/0x117
[ 0.816692] [<ffffffff812bd56b>] ? really_probe+0xc0/0x14d
[ 0.816696] [<ffffffff812bd6fe>] ? driver_probe_device+0x37/0x52
[ 0.816700] [<ffffffff812bd773>] ? __driver_attach+0x5a/0x7d
[ 0.816704] [<ffffffff812bd719>] ? __driver_attach+0x0/0x7d
[ 0.816708] [<ffffffff812bc85d>] ? bus_for_each_dev+0x54/0x88
[ 0.816712] [<ffffffff812bd319>] ? driver_attach+0x19/0x1b
[ 0.816715] [<ffffffff812bcf6d>] ? bus_add_driver+0xab/0x201
[ 0.816719] [<ffffffff812bd976>] ? driver_register+0xb2/0x11f
[ 0.816724] [<ffffffff81b3cf29>] ? acpi_video_init+0x0/0x17
[ 0.816729] [<ffffffff8124a29e>] ? acpi_bus_register_driver+0x3e/0x40
[ 0.816732] [<ffffffff8126c8c5>] ? acpi_video_register+0x1b/0x34
[ 0.816736] [<ffffffff81b3cf3e>] ? acpi_video_init+0x15/0x17
[ 0.816741] [<ffffffff8100020a>] ? do_one_initcall+0x7a/0x130
[ 0.816746] [<ffffffff81b1bc0e>] ? kernel_init+0xe1/0x15b
[ 0.816750] [<ffffffff81002f94>] ? kernel_thread_helper+0x4/0x10
[ 0.816754] [<ffffffff8102a634>] ? finish_task_switch+0x3f/0xe3
[ 0.816759] [<ffffffff8155ab44>] ? restore_args+0x0/0x30
[ 0.816763] [<ffffffff81b1bb2d>] ? kernel_init+0x0/0x15b
[ 0.816766] [<ffffffff81002f90>] ? kernel_thread_helper+0x0/0x10
[ 0.816804] ---[ end trace 6d450e935ee1897c ]---
[ 0.816808] ACPI: Create sysfs link
[ 0.817274] acpi device:38: registered as cooling_device0
[ 0.818068] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A03:00/device:36/LNXVIDEO:00/input/input3
[ 0.818077] ACPI: Video Device [VID] (multi-head: yes rom: no post: no)
[ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
[ 0.818369] ACPI: acpi_idle registered with cpuidle
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card
2011-03-03 23:50 ` mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card Valdis.Kletnieks
@ 2011-03-04 0:05 ` Greg KH
2011-03-04 4:28 ` Valdis.Kletnieks
0 siblings, 1 reply; 20+ messages in thread
From: Greg KH @ 2011-03-04 0:05 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: akpm, Len Brown, linux-kernel, linux-acpi
On Thu, Mar 03, 2011 at 06:50:41PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 02 Mar 2011 16:52:55 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Dell Latitude E6500, with an NVidia G98M (Quadro NVS 160M) graphics card.
>
> Seen in my dmesg - it's had the 'Firmware Bug' message for roughly forever, but
> apparently somewhere recently a warning crawled in. 2.6.38-rc5-next-20110222
> did not throw the warning, jsut the firmware bug msg.
>
> Hope somebody recognizes it, I won't be able to bisect this one for a bit (I
> have 2 or 3 other things I have a bigger need to track down).
>
> [ 0.784712] ACPI: Sleep Button [SBTN]
> [ 0.816626] ------------[ cut here ]------------
> [ 0.816633] WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0x88/0x9c()
> [ 0.816635] Hardware name: Latitude E6500
> [ 0.816637] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:01.0/0000:01:00.0/backlight/acpi_video0/device'
> [ 0.816640] Modules linked in:
> [ 0.816645] Pid: 1, comm: swapper Not tainted 2.6.38-rc7-mmotm0302 #2
> [ 0.816647] Call Trace:
> [ 0.816652] [<ffffffff8103899e>] ? warn_slowpath_common+0x7e/0x96
> [ 0.816657] [<ffffffff81038a4a>] ? warn_slowpath_fmt+0x41/0x43
> [ 0.816661] [<ffffffff8114d876>] ? sysfs_add_one+0x88/0x9c
> [ 0.816665] [<ffffffff8114e06e>] ? sysfs_do_create_link+0x145/0x1d5
> [ 0.816669] [<ffffffff8114e10c>] ? sysfs_create_link+0xe/0x10
> [ 0.816674] [<ffffffff8126cef1>] ? acpi_video_device_find_cap+0x1f5/0x2de
> [ 0.816678] [<ffffffff8126d196>] ? acpi_video_bus_get_one_device+0x1bc/0x250
> [ 0.816682] [<ffffffff8126d3f8>] ? acpi_video_bus_add+0x1ce/0x36e
> [ 0.816687] [<ffffffff8124983d>] ? acpi_device_probe+0x49/0x117
> [ 0.816692] [<ffffffff812bd56b>] ? really_probe+0xc0/0x14d
> [ 0.816696] [<ffffffff812bd6fe>] ? driver_probe_device+0x37/0x52
> [ 0.816700] [<ffffffff812bd773>] ? __driver_attach+0x5a/0x7d
> [ 0.816704] [<ffffffff812bd719>] ? __driver_attach+0x0/0x7d
> [ 0.816708] [<ffffffff812bc85d>] ? bus_for_each_dev+0x54/0x88
> [ 0.816712] [<ffffffff812bd319>] ? driver_attach+0x19/0x1b
> [ 0.816715] [<ffffffff812bcf6d>] ? bus_add_driver+0xab/0x201
> [ 0.816719] [<ffffffff812bd976>] ? driver_register+0xb2/0x11f
> [ 0.816724] [<ffffffff81b3cf29>] ? acpi_video_init+0x0/0x17
> [ 0.816729] [<ffffffff8124a29e>] ? acpi_bus_register_driver+0x3e/0x40
> [ 0.816732] [<ffffffff8126c8c5>] ? acpi_video_register+0x1b/0x34
> [ 0.816736] [<ffffffff81b3cf3e>] ? acpi_video_init+0x15/0x17
> [ 0.816741] [<ffffffff8100020a>] ? do_one_initcall+0x7a/0x130
> [ 0.816746] [<ffffffff81b1bc0e>] ? kernel_init+0xe1/0x15b
> [ 0.816750] [<ffffffff81002f94>] ? kernel_thread_helper+0x4/0x10
> [ 0.816754] [<ffffffff8102a634>] ? finish_task_switch+0x3f/0xe3
> [ 0.816759] [<ffffffff8155ab44>] ? restore_args+0x0/0x30
> [ 0.816763] [<ffffffff81b1bb2d>] ? kernel_init+0x0/0x15b
> [ 0.816766] [<ffffffff81002f90>] ? kernel_thread_helper+0x0/0x10
> [ 0.816804] ---[ end trace 6d450e935ee1897c ]---
> [ 0.816808] ACPI: Create sysfs link
> [ 0.817274] acpi device:38: registered as cooling_device0
> [ 0.818068] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A03:00/device:36/LNXVIDEO:00/input/input3
> [ 0.818077] ACPI: Video Device [VID] (multi-head: yes rom: no post: no)
> [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
Have you tried this option?
There's nothing sysfs can do here, sorry, it really looks like you have
a BIOS/firmware problem.
good luck,
greg k-h
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card
2011-03-04 0:05 ` Greg KH
@ 2011-03-04 4:28 ` Valdis.Kletnieks
2011-03-04 5:25 ` Zhang Rui
0 siblings, 1 reply; 20+ messages in thread
From: Valdis.Kletnieks @ 2011-03-04 4:28 UTC (permalink / raw)
To: Greg KH; +Cc: akpm, Len Brown, linux-kernel, linux-acpi
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On Thu, 03 Mar 2011 16:05:50 PST, Greg KH said:
> > [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
>
> Have you tried this option?
>
> There's nothing sysfs can do here, sorry, it really looks like you have
> a BIOS/firmware problem.
Well, (a) it's been saying "try it if the current driver doesn't work" - and
things have worked just fine all along (or more properly, if it's broken in
behavior, I haven't actually seen the effects...)
and (b) Something changed very recently to add the WARNING, which wasn't there
in rc5-next-2011022.
And (c) I doubt that's going to fix the WARNING, because looking at drivers/
acpi/video.c, the variable allow_duplicates is checked in exactly *ONE* place,
which is *after* the printk:
if (status == AE_ALREADY_EXISTS) {
printk(KERN_WARNING FW_BUG
"Duplicate ACPI video bus devices for the"
" same VGA controller, please try module "
"parameter \"video.allow_duplicates=1\""
"if the current driver doesn't work.\n");
if (!allow_duplicates)
return -ENODEV;
}
So since the warning triggers before we see the printk(), setting the variable
won't make a difference because we warn before we ever get into that if
statement.
Now, maybe we need to be checking allow_duplicates earlier and/or in other
places - but I'll let somebody who actually understands the code to decide taht. ;)
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card
2011-03-04 4:28 ` Valdis.Kletnieks
@ 2011-03-04 5:25 ` Zhang Rui
0 siblings, 0 replies; 20+ messages in thread
From: Zhang Rui @ 2011-03-04 5:25 UTC (permalink / raw)
To: Valdis.Kletnieks@vt.edu
Cc: Greg KH, akpm@linux-foundation.org, Len Brown,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
On Fri, 2011-03-04 at 12:28 +0800, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 03 Mar 2011 16:05:50 PST, Greg KH said:
>
> > > [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
> >
> > Have you tried this option?
> >
> > There's nothing sysfs can do here, sorry, it really looks like you have
> > a BIOS/firmware problem.
>
right.
this warning message is printed out because there are two ACPI devices
for the same VGA controller, and Linux has no idea which can actually
change the backlight.
> Well, (a) it's been saying "try it if the current driver doesn't work" - and
> things have worked just fine all along (or more properly, if it's broken in
> behavior, I haven't actually seen the effects...)
>
> and (b) Something changed very recently to add the WARNING, which wasn't there
> in rc5-next-2011022.
>
well. c504f8cb has been shipped in 2.6.33-rc5.
can you attach the acpidump output of this machine please?
please attach the dmesg output both with and without this warning.
please attach the output of "grep . /sys/bus/acpi/drivers/video/*/path"
in both kernels.
> And (c) I doubt that's going to fix the WARNING, because looking at drivers/
> acpi/video.c, the variable allow_duplicates is checked in exactly *ONE* place,
> which is *after* the printk:
>
> if (status == AE_ALREADY_EXISTS) {
> printk(KERN_WARNING FW_BUG
> "Duplicate ACPI video bus devices for the"
> " same VGA controller, please try module "
> "parameter \"video.allow_duplicates=1\""
> "if the current driver doesn't work.\n");
> if (!allow_duplicates)
> return -ENODEV;
> }
>
> So since the warning triggers before we see the printk(), setting the variable
> won't make a difference because we warn before we ever get into that if
> statement.
>
> Now, maybe we need to be checking allow_duplicates earlier and/or in other
> places - but I'll let somebody who actually understands the code to decide taht. ;)
^ permalink raw reply [flat|nested] 20+ messages in thread
* tun: Failed to create tun sysfs files [was: mmotm 2011-03-02-16-52 uploaded]
2011-03-03 0:52 mmotm 2011-03-02-16-52 uploaded akpm
` (3 preceding siblings ...)
2011-03-03 23:50 ` mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card Valdis.Kletnieks
@ 2011-03-04 8:56 ` Jiri Slaby
2011-03-04 9:06 ` tun: Failed to create tun sysfs files David Miller
4 siblings, 1 reply; 20+ messages in thread
From: Jiri Slaby @ 2011-03-04 8:56 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, mm-commits, Jiri Slaby, ML netdev, maxk, vtun
On 03/03/2011 01:52 AM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
Hi, I'm seeing this with tun (also with earlier versions):
WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0xb8/0xe0()
Hardware name: To Be Filled By O.E.M.
sysfs: cannot create duplicate filename '/devices/virtual/net/tun0/group'
Modules linked in: microcode dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
Pid: 3840, comm: openvpn Not tainted 2.6.38-rc4-mm1_64+ #1390
Call Trace:
[<ffffffff8106d61a>] ? warn_slowpath_common+0x7a/0xb0
[<ffffffff8106d6f1>] ? warn_slowpath_fmt+0x41/0x50
[<ffffffff81176638>] ? sysfs_add_one+0xb8/0xe0
[<ffffffff8117570d>] ? sysfs_add_file_mode+0x5d/0xa0
[<ffffffff8117575c>] ? sysfs_add_file+0xc/0x10
[<ffffffff81175841>] ? sysfs_create_file+0x21/0x40
[<ffffffff813609d4>] ? device_create_file+0x14/0x20
[<ffffffff813e0256>] ? tun_set_iff+0x3f6/0x4a0
[<ffffffff813e05fe>] ? __tun_chr_ioctl+0x12e/0x5d0
[<ffffffff8126c5c2>] ? __strncpy_from_user+0x22/0x60
[<ffffffff813e0ade>] ? tun_chr_ioctl+0xe/0x10
[<ffffffff811274ed>] ? do_vfs_ioctl+0x8d/0x300
[<ffffffff811277aa>] ? sys_ioctl+0x4a/0x80
[<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
It's because these devices already contain 'group' in the sysfs dir.
regards,
--
js
suse labs
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: tun: Failed to create tun sysfs files
2011-03-04 8:56 ` tun: Failed to create tun sysfs files [was: mmotm 2011-03-02-16-52 uploaded] Jiri Slaby
@ 2011-03-04 9:06 ` David Miller
2011-03-04 9:37 ` Jiri Slaby
0 siblings, 1 reply; 20+ messages in thread
From: David Miller @ 2011-03-04 9:06 UTC (permalink / raw)
To: jslaby; +Cc: linux-kernel, akpm, mm-commits, jirislaby, netdev, maxk, vtun
From: Jiri Slaby <jslaby@suse.cz>
Date: Fri, 04 Mar 2011 09:56:09 +0100
> On 03/03/2011 01:52 AM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> Hi, I'm seeing this with tun (also with earlier versions):
The name of the attribute was changed to netdev_group in order to
fix this problem, in fact quite some time ago.
See the last entry of the net_class_attributes array in
net/core/net-sysfs.c, if it isn't called "netdev_group"
something is awry.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: tun: Failed to create tun sysfs files
2011-03-04 9:06 ` tun: Failed to create tun sysfs files David Miller
@ 2011-03-04 9:37 ` Jiri Slaby
2011-03-05 8:04 ` tun routing is broken [was: tun: Failed to create tun sysfs files] Jiri Slaby
0 siblings, 1 reply; 20+ messages in thread
From: Jiri Slaby @ 2011-03-04 9:37 UTC (permalink / raw)
To: David Miller; +Cc: jslaby, linux-kernel, akpm, mm-commits, netdev, maxk, vtun
On 03/04/2011 10:06 AM, David Miller wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> Date: Fri, 04 Mar 2011 09:56:09 +0100
>
>> On 03/03/2011 01:52 AM, akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>>
>> Hi, I'm seeing this with tun (also with earlier versions):
>
> The name of the attribute was changed to netdev_group in order to
> fix this problem, in fact quite some time ago.
>
> See the last entry of the net_class_attributes array in
> net/core/net-sysfs.c, if it isn't called "netdev_group"
> something is awry.
<idiocy>
Aha, sorry for the noise, I booted the old kernel.
</idiocy>
thanks,
--
js
^ permalink raw reply [flat|nested] 20+ messages in thread
* tun routing is broken [was: tun: Failed to create tun sysfs files]
2011-03-04 9:37 ` Jiri Slaby
@ 2011-03-05 8:04 ` Jiri Slaby
2011-03-05 8:10 ` tun routing is broken David Miller
0 siblings, 1 reply; 20+ messages in thread
From: Jiri Slaby @ 2011-03-05 8:04 UTC (permalink / raw)
To: David Miller; +Cc: Jiri Slaby, linux-kernel, akpm, mm-commits, netdev, maxk
On 03/04/2011 10:37 AM, Jiri Slaby wrote:
> On 03/04/2011 10:06 AM, David Miller wrote:
>> From: Jiri Slaby <jslaby@suse.cz>
>> Date: Fri, 04 Mar 2011 09:56:09 +0100
>>
>>> On 03/03/2011 01:52 AM, akpm@linux-foundation.org wrote:
>>>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>>>
>>> Hi, I'm seeing this with tun (also with earlier versions):
>>
>> The name of the attribute was changed to netdev_group in order to
>> fix this problem, in fact quite some time ago.
>>
>> See the last entry of the net_class_attributes array in
>> net/core/net-sysfs.c, if it isn't called "netdev_group"
>> something is awry.
>
> <idiocy>
> Aha, sorry for the noise, I booted the old kernel.
> </idiocy>
Ok, so I booted the new kernel, and tun is broken there completely. If I
try to ping a vpn peer:
...
capget(0x20080522, 0, NULL) = 0
capset(0x20080522, 0, {0, 0, 0}) = 0
socket(PF_INET, SOCK_DGRAM, IPPROTO_IP) = 4
connect(4, {sa_family=AF_INET, sin_port=htons(1025),
sin_addr=inet_addr("10.20.11.1")}, 16) = -1 EINVAL (Invalid argument)
the route is:
10.20.11.1 dev tun0 proto kernel scope link src 10.20.11.33
When I try to ping a router on eth0 10.0.28.10, it works as expected.
Maybe the changes in ipv4 routing cause this? But my amateur eyes can't
see any breakage there...
Now I'm back in mmotm 2011-02-10-16-26 and it works, indeed.
regards,
--
js
suse labs
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: tun routing is broken
2011-03-05 8:04 ` tun routing is broken [was: tun: Failed to create tun sysfs files] Jiri Slaby
@ 2011-03-05 8:10 ` David Miller
2011-03-05 8:17 ` Jiri Slaby
2011-03-05 11:48 ` Valdis.Kletnieks
0 siblings, 2 replies; 20+ messages in thread
From: David Miller @ 2011-03-05 8:10 UTC (permalink / raw)
To: jslaby; +Cc: jirislaby, linux-kernel, akpm, mm-commits, netdev, maxk
From: Jiri Slaby <jslaby@suse.cz>
Date: Sat, 05 Mar 2011 09:04:22 +0100
> Ok, so I booted the new kernel, and tun is broken there completely. If I
> try to ping a vpn peer:
-mm tree is missing this fix which went in yesterday. Please if
you are going to be testing networking a lot, test against net-next-2.6
instead of Andrew's tree which invariable lags behind:
--------------------
ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Reported-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/ipv4/devinet.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 9038928..ff53860 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -111,7 +111,7 @@ static inline unsigned int inet_addr_hash(struct net *net, __be32 addr)
static void inet_hash_insert(struct net *net, struct in_ifaddr *ifa)
{
- unsigned int hash = inet_addr_hash(net, ifa->ifa_address);
+ unsigned int hash = inet_addr_hash(net, ifa->ifa_local);
spin_lock(&inet_addr_hash_lock);
hlist_add_head_rcu(&ifa->hash, &inet_addr_lst[hash]);
@@ -146,7 +146,7 @@ struct net_device *__ip_dev_find(struct net *net, __be32 addr, bool devref)
if (!net_eq(dev_net(dev), net))
continue;
- if (ifa->ifa_address == addr) {
+ if (ifa->ifa_local == addr) {
result = dev;
break;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: tun routing is broken
2011-03-05 8:10 ` tun routing is broken David Miller
@ 2011-03-05 8:17 ` Jiri Slaby
2011-03-05 8:26 ` Jiri Slaby
2011-03-07 12:54 ` Jiri Kosina
2011-03-05 11:48 ` Valdis.Kletnieks
1 sibling, 2 replies; 20+ messages in thread
From: Jiri Slaby @ 2011-03-05 8:17 UTC (permalink / raw)
To: David Miller; +Cc: Jiri Slaby, linux-kernel, akpm, mm-commits, netdev, maxk
On 03/05/2011 09:10 AM, David Miller wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> Date: Sat, 05 Mar 2011 09:04:22 +0100
>
>> Ok, so I booted the new kernel, and tun is broken there completely. If I
>> try to ping a vpn peer:
>
> -mm tree is missing this fix which went in yesterday. Please if
> you are going to be testing networking a lot, test against net-next-2.6
> instead of Andrew's tree which invariable lags behind:
I'm not testing networking, I'm just using my desktop :). (And
next/master is mostly unusable for these needs. In comparison to mmotm
which is some kind of a "release".)
> --------------------
> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
It would be great to have a References: tag or better changelog. Then I
would give the commit a shot. The way it is I ignored it when looking at
next/master inside net/ipv4/ changes for commits to test.
Going to boot with this change.
> Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> Reported-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/ipv4/devinet.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 9038928..ff53860 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -111,7 +111,7 @@ static inline unsigned int inet_addr_hash(struct net *net, __be32 addr)
>
> static void inet_hash_insert(struct net *net, struct in_ifaddr *ifa)
> {
> - unsigned int hash = inet_addr_hash(net, ifa->ifa_address);
> + unsigned int hash = inet_addr_hash(net, ifa->ifa_local);
>
> spin_lock(&inet_addr_hash_lock);
> hlist_add_head_rcu(&ifa->hash, &inet_addr_lst[hash]);
> @@ -146,7 +146,7 @@ struct net_device *__ip_dev_find(struct net *net, __be32 addr, bool devref)
>
> if (!net_eq(dev_net(dev), net))
> continue;
> - if (ifa->ifa_address == addr) {
> + if (ifa->ifa_local == addr) {
> result = dev;
> break;
> }
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: tun routing is broken
2011-03-05 8:17 ` Jiri Slaby
@ 2011-03-05 8:26 ` Jiri Slaby
2011-03-07 12:54 ` Jiri Kosina
1 sibling, 0 replies; 20+ messages in thread
From: Jiri Slaby @ 2011-03-05 8:26 UTC (permalink / raw)
To: Jiri Slaby; +Cc: David Miller, linux-kernel, akpm, mm-commits, netdev, maxk
On 03/05/2011 09:17 AM, Jiri Slaby wrote:
>> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
>
> It would be great to have a References: tag or better changelog. Then I
> would give the commit a shot. The way it is I ignored it when looking at
> next/master inside net/ipv4/ changes for commits to test.
>
> Going to boot with this change.
Yes, it works.
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: tun routing is broken
2011-03-05 8:17 ` Jiri Slaby
2011-03-05 8:26 ` Jiri Slaby
@ 2011-03-07 12:54 ` Jiri Kosina
1 sibling, 0 replies; 20+ messages in thread
From: Jiri Kosina @ 2011-03-07 12:54 UTC (permalink / raw)
To: Jiri Slaby, Andrew Morton
Cc: David Miller, Jiri Slaby, linux-kernel, mm-commits, netdev, maxk
On Sat, 5 Mar 2011, Jiri Slaby wrote:
> > Date: Sat, 05 Mar 2011 09:04:22 +0100
> >
> >> Ok, so I booted the new kernel, and tun is broken there completely. If I
> >> try to ping a vpn peer:
> >
> > -mm tree is missing this fix which went in yesterday. Please if
> > you are going to be testing networking a lot, test against net-next-2.6
> > instead of Andrew's tree which invariable lags behind:
>
> I'm not testing networking, I'm just using my desktop :). (And
> next/master is mostly unusable for these needs. In comparison to mmotm
> which is some kind of a "release".)
I have been hit by similar issues several times already as well.
I guess that question of including -mm into linux-next should be raised
again here ... Andrew, if I remember correctly, on last kernel summit you
were stating that you'd stop eating untill you have -mm included in -next.
Seems like you must be quite hungry these days already :)
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: tun routing is broken
2011-03-05 8:10 ` tun routing is broken David Miller
2011-03-05 8:17 ` Jiri Slaby
@ 2011-03-05 11:48 ` Valdis.Kletnieks
1 sibling, 0 replies; 20+ messages in thread
From: Valdis.Kletnieks @ 2011-03-05 11:48 UTC (permalink / raw)
To: David Miller
Cc: jslaby, jirislaby, linux-kernel, akpm, mm-commits, netdev, maxk
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Sat, 05 Mar 2011 00:10:22 PST, David Miller said:
> --------------------
> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
>
> Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> Reported-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/ipv4/devinet.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 9038928..ff53860 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
Confirming this fixes the problem I reported with IPv4 over PPP as well, thanks.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread