* [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
@ 2011-03-04 22:09 Sheetal Sahasrabudhe
2011-03-04 22:42 ` Bryan Huntsman
2011-03-07 10:06 ` Jean Pihet
0 siblings, 2 replies; 4+ messages in thread
From: Sheetal Sahasrabudhe @ 2011-03-04 22:09 UTC (permalink / raw)
To: linux-arm-kernel
Cc: will.deacon, jamie.iles, jean.pihet, robert.richter, dwalker,
bryanh, davidb, linux-arm-msm, linux-kernel, Sheetal Sahasrabudhe
This patchset contains the following features:
It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
and Oprofile.
It adds PMU support for Scorpion and ScorpionMP.
It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
Sheetal Sahasrabudhe (3):
msm: Add support for Scorpion and ScorpionMP PMU
[ARM] perfevents: Add support for Scorpion performance monitors
[ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
arch/arm/include/asm/perf_event.h | 2 +
arch/arm/kernel/perf_event.c | 11 +
arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
arch/arm/mach-msm/Makefile | 2 +
arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
arch/arm/mach-msm/pmu.c | 36 ++
arch/arm/oprofile/common.c | 4 +
10 files changed, 736 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/kernel/perf_event_qc.c
create mode 100644 arch/arm/mach-msm/pmu.c
--
1.7.4.1
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
2011-03-04 22:09 [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile Sheetal Sahasrabudhe
@ 2011-03-04 22:42 ` Bryan Huntsman
2011-03-05 21:40 ` Sheetal Sahasrabudhe
2011-03-07 10:06 ` Jean Pihet
1 sibling, 1 reply; 4+ messages in thread
From: Bryan Huntsman @ 2011-03-04 22:42 UTC (permalink / raw)
To: Sheetal Sahasrabudhe
Cc: linux-arm-kernel, will.deacon, jamie.iles, jean.pihet,
robert.richter, dwalker, davidb, linux-arm-msm, linux-kernel
On 03/04/2011 02:09 PM, Sheetal Sahasrabudhe wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> msm: Add support for Scorpion and ScorpionMP PMU
> [ARM] perfevents: Add support for Scorpion performance monitors
> [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> arch/arm/include/asm/perf_event.h | 2 +
> arch/arm/kernel/perf_event.c | 11 +
> arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
> arch/arm/mach-msm/Makefile | 2 +
> arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
> arch/arm/mach-msm/pmu.c | 36 ++
> arch/arm/oprofile/common.c | 4 +
> 10 files changed, 736 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/kernel/perf_event_qc.c
> create mode 100644 arch/arm/mach-msm/pmu.c
>
Some minor comments from a quick review:
- you're using multi-line commenting style for single line comments
- see Documentation/CodingStyle, Chapter 8, for preferred multi-line
commenting style
- 'mv perf_event_qc.c perf_event_msm.c'?
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
2011-03-04 22:42 ` Bryan Huntsman
@ 2011-03-05 21:40 ` Sheetal Sahasrabudhe
0 siblings, 0 replies; 4+ messages in thread
From: Sheetal Sahasrabudhe @ 2011-03-05 21:40 UTC (permalink / raw)
To: Bryan Huntsman
Cc: Sheetal Sahasrabudhe, linux-arm-kernel, will.deacon, jamie.iles,
jean.pihet, robert.richter, dwalker, davidb, linux-arm-msm,
linux-kernel
Hi Bryan,
> Some minor comments from a quick review:
> - you're using multi-line commenting style for single line comments
> - see Documentation/CodingStyle, Chapter 8, for preferred multi-line
> commenting style
I will fix the commenting style wherever needed.
> - 'mv perf_event_qc.c perf_event_msm.c'?
That's fine with me.
Thanks,
Sheetal
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
2011-03-04 22:09 [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile Sheetal Sahasrabudhe
2011-03-04 22:42 ` Bryan Huntsman
@ 2011-03-07 10:06 ` Jean Pihet
1 sibling, 0 replies; 4+ messages in thread
From: Jean Pihet @ 2011-03-07 10:06 UTC (permalink / raw)
To: Sheetal Sahasrabudhe
Cc: linux-arm-kernel, will.deacon, jamie.iles, robert.richter,
dwalker, bryanh, davidb, linux-arm-msm, linux-kernel
Hi,
On Fri, Mar 4, 2011 at 11:09 PM, Sheetal Sahasrabudhe
<sheetals@codeaurora.org> wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> msm: Add support for Scorpion and ScorpionMP PMU
> [ARM] perfevents: Add support for Scorpion performance monitors
> [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> arch/arm/include/asm/perf_event.h | 2 +
> arch/arm/kernel/perf_event.c | 11 +
> arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
> arch/arm/mach-msm/Makefile | 2 +
> arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
> arch/arm/mach-msm/pmu.c | 36 ++
> arch/arm/oprofile/common.c | 4 +
> 10 files changed, 736 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/kernel/perf_event_qc.c
> create mode 100644 arch/arm/mach-msm/pmu.c
>
I cannot test on the actual HW so here is the review ack:
Reviewed-by: Jean Pihet <j-pihet@ti.com>
Thanks,
Jean
> --
> 1.7.4.1
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-07 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-04 22:09 [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile Sheetal Sahasrabudhe
2011-03-04 22:42 ` Bryan Huntsman
2011-03-05 21:40 ` Sheetal Sahasrabudhe
2011-03-07 10:06 ` Jean Pihet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).