From: Trilok Soni <tsoni@codeaurora.org>
To: Sheetal Sahasrabudhe <sheetals@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
dwalker@fifo99.com, bryanh@codeaurora.org, davidb@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU
Date: Sat, 05 Mar 2011 14:13:12 +0530 [thread overview]
Message-ID: <4D71F7A0.5010101@codeaurora.org> (raw)
In-Reply-To: <1299276583-12542-1-git-send-email-sheetals@codeaurora.org>
Hi Sheetal,
> +static int __init scorpion_pmu_init(void)
> +{
> + platform_device_register(&pmu_device);
platform_device_register can fail. Better do it like
"return platform_device_register(&pmu_device);
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-05 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 22:09 [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU Sheetal Sahasrabudhe
2011-03-05 8:43 ` Trilok Soni [this message]
2011-03-05 21:18 ` Sheetal Sahasrabudhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D71F7A0.5010101@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sheetals@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).