From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754997Ab1CHCQQ (ORCPT ); Mon, 7 Mar 2011 21:16:16 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:56901 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752775Ab1CHCQM (ORCPT ); Mon, 7 Mar 2011 21:16:12 -0500 Message-ID: <4D7591C5.5070909@cn.fujitsu.com> Date: Tue, 08 Mar 2011 10:17:41 +0800 From: Lai Jiangshan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: Hugh Dickins , Christoph Lameter CC: Pekka Enberg , Ingo Molnar , "Paul E. McKenney" , Eric Dumazet , "David S. Miller" , Matt Mackall , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/4] slub,rcu: don't assume the size of struct rcu_head References: <4D6CA852.3060303@cn.fujitsu.com> In-Reply-To: X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-03-08 10:14:57, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-03-08 10:14:57, Serialize complete at 2011-03-08 10:14:57 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2011 03:39 AM, Hugh Dickins wrote: > On Wed, Mar 2, 2011 at 4:32 AM, Christoph Lameter wrote: >> On Tue, 1 Mar 2011, Hugh Dickins wrote: >> >>>> Struct page may be larger for debugging purposes already because of the >>>> need for extended spinlock data. >>> >>> That was so for a long time, but I stopped it just over a year ago >>> with commit a70caa8ba48f21f46d3b4e71b6b8d14080bbd57a, stop ptlock >>> enlarging struct page. >> >> Strange. I just played around with in in January and the page struct size >> changes when I build kernels with full debugging. I have some >> cmpxchg_double patches here that depend on certain alignment in the page >> struct. Debugging causes all that stuff to get out of whack so that I had >> to do some special patches to make sure fields following the spinlock are >> properly aligned when the sizes change. > > That puzzles me, it's not my experience and I don't have an > explanation: do you have time to investigate? > > Uh oh, you're going to tell me you're working on an out-of-tree > architecture with a million cpus ;) In that case, yes, I'm afraid > I'll have to update the SPLIT_PTLOCK_CPUS defaulting (for a million - > 1 even). > >> >>> If a union leads to "random junk" overwriting the page->mapping field >>> when the page is reused, and that junk could resemble the pointer in >>> question, then KSM would mistakenly think it still owned the page. >>> Very remote chance, and maybe it amounts to no more than a leak. But >>> I'd still prefer we keep page->mapping for pointers (sometimes with >>> lower bits set as flags). >> >> DESTROY BY RCU uses the lru field which follows the mapping field in page >> struct. Why would random junk overwrite the mapping field? > > Random junk does not overwrite the mapping field with the current > implementation of DESTROY_BY_RCU. But you and Jiangshan were > discussing how to change it, so I was warning of this issue with > page->mapping. > > But I would anyway agree with Jiangshan, that it's preferable not to > bloat struct page size just for this DESTROY_BY_RCU issue, even if it > is only an issue when debugging. > A union with rcu_head does not cause overwriting, But the problem is only one minority use of the page (as a DESTROY_BY_RCU slab) needs to fit a rcu_head and to bloat the struct page size. Except for preparing for debugging or adding priority information for rcu_head, this patch also does a de-coupling work.