linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][resend] blk-cgroup: Lower minimum weight from 100 to 10.
@ 2011-03-08 16:04 Justin TerAvest
  2011-03-08 18:45 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Justin TerAvest @ 2011-03-08 16:04 UTC (permalink / raw)
  To: vgoyal, jaxboe; +Cc: ctalbott, guijianfeng, linux-kernel, Justin TerAvest

We've found that we still get good, useful isolation at weights this
low. I'd like to adjust the minimum so that any other changes can take
these values into account.

Signed-off-by: Justin TerAvest <teravest@google.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
---
 Documentation/cgroups/blkio-controller.txt |    2 +-
 block/blk-cgroup.h                         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt
index 4ed7b5c..24314fd 100644
--- a/Documentation/cgroups/blkio-controller.txt
+++ b/Documentation/cgroups/blkio-controller.txt
@@ -140,7 +140,7 @@ Proportional weight policy files
 	- Specifies per cgroup weight. This is default weight of the group
 	  on all the devices until and unless overridden by per device rule.
 	  (See blkio.weight_device).
-	  Currently allowed range of weights is from 100 to 1000.
+	  Currently allowed range of weights is from 10 to 1000.
 
 - blkio.weight_device
 	- One can specify per cgroup per device rules using this interface.
diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
index ea4861b..57e7234 100644
--- a/block/blk-cgroup.h
+++ b/block/blk-cgroup.h
@@ -240,7 +240,7 @@ static inline char *blkg_path(struct blkio_group *blkg) { return NULL; }
 
 #endif
 
-#define BLKIO_WEIGHT_MIN	100
+#define BLKIO_WEIGHT_MIN	10
 #define BLKIO_WEIGHT_MAX	1000
 #define BLKIO_WEIGHT_DEFAULT	500
 
-- 
1.7.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][resend] blk-cgroup: Lower minimum weight from 100 to 10.
  2011-03-08 16:04 [PATCH][resend] blk-cgroup: Lower minimum weight from 100 to 10 Justin TerAvest
@ 2011-03-08 18:45 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-03-08 18:45 UTC (permalink / raw)
  To: Justin TerAvest
  Cc: vgoyal@redhat.com, ctalbott@google.com,
	guijianfeng@cn.fujitsu.com, linux-kernel@vger.kernel.org

On 2011-03-08 17:04, Justin TerAvest wrote:
> We've found that we still get good, useful isolation at weights this
> low. I'd like to adjust the minimum so that any other changes can take
> these values into account.

Thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-08 18:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 16:04 [PATCH][resend] blk-cgroup: Lower minimum weight from 100 to 10 Justin TerAvest
2011-03-08 18:45 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).