From: Jens Axboe <jaxboe@fusionio.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kay.sievers@vrfy.org>,
<hch@infradead.org>
Subject: Re: [PATCHSET] block: Convert block drivers to ->check_events(), take#2
Date: Wed, 9 Mar 2011 15:49:58 +0100 [thread overview]
Message-ID: <4D779396.7050905@fusionio.com> (raw)
In-Reply-To: <4D774641.3070806@kernel.dk>
On 2011-03-09 10:20, Jens Axboe wrote:
> On 2011-03-09 10:13, Tejun Heo wrote:
>> Hello,
>>
>> This is the second take of convert-block-drivers-to-check_events
>> patchset. Other than addition of Acked-by's and rebasing on top of
>> the current block:for-2.6.39/core (df457f845e), nothing really
>> changed.
>
> Thanks Tejun, applied.
No worky:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000238
IP: [<ffffffff81216741>] disk_unblock_events+0x1/0x20
PGD 87573c067 PUD 877a29067 PMD 0
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/net/lo/operstate
CPU 3
Modules linked in: hid_apple usbhid uhci_hcd
input: Mitsumi Electric Apple Extended USB Keyboard as /devices/pci0000:00/0000:00:1d.2/usb8/8-1/8-1.1/8-1.1.3/8-1.1.3:1.0/input/input6
generic-usb 0003:05AC:020B.0005: input: USB HID v1.10 Keyboard [Mitsumi Electric Apple Extended USB Keyboard] on usb-0000:00:1d.2-1.1.3/input0
input: Mitsumi Electric Apple Extended USB Keyboard as /devices/pci0000:00/0000:00:1d.2/usb8/8-1/8-1.1/8-1.1.3/8-1.1.3:1.1/input/input7
generic-usb 0003:05AC:020B.0006: input: USB HID v1.10 Device [Mitsumi Electric Apple Extended USB Keyboard] on usb-0000:00:1d.2-1.1.3/input1
ehci_hcd igb usbcore ahci libahci nls_base
Pid: 4283, comm: swapon Not tainted 2.6.38-rc6+ #40 QCI QSSC-S4R/QSSC-S4R
RIP: 0010:[<ffffffff81216741>] [<ffffffff81216741>] disk_unblock_events+0x1/0x20
RSP: 0018:ffff880674183b78 EFLAGS: 00010202
RAX: 0000000000000000 RBX: ffff8808774c5040 RCX: ffff880477b20800
RDX: ffff8808774c5040 RSI: 000000000000001d RDI: 0000000000000000
RBP: ffff880674183bd8 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000010 R12: 0000000000000000
R13: ffff8808774c5060 R14: 0000000000000000 R15: 000000000000001d
FS: 00007f8e9f34b740(0000) GS:ffff88087fc00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000238 CR3: 0000000875761000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process swapon (pid: 4283, threadinfo ffff880674182000, task ffff880676632090)
Stack:
ffff880674183bd8 ffffffff8112a388 ffff8808774c5040 00000001812230c7
ffff880674183bb8 0000000076536c48 ffff880674183bb8 ffff8808775aaa80
ffff880276536c00 ffff8808775aaaa0 0000000000000004 000000000000001d
Call Trace:
[<ffffffff8112a388>] ? __blkdev_get+0x168/0x3b0
[<ffffffff8112a444>] __blkdev_get+0x224/0x3b0
[<ffffffff8112a8e0>] ? blkdev_open+0x0/0x80
[<ffffffff8112a61f>] blkdev_get+0x4f/0x310
[<ffffffff8112988a>] ? bdget+0x10a/0x120
[<ffffffff8112a8e0>] ? blkdev_open+0x0/0x80
[<ffffffff8112a940>] blkdev_open+0x60/0x80
[<ffffffff810f6410>] __dentry_open+0x100/0x360
[<ffffffff81101f9e>] ? generic_permission+0x1e/0xb0
[<ffffffff810f6791>] nameidata_to_filp+0x71/0x80
[<ffffffff81104318>] finish_open+0xc8/0x1a0
[<ffffffff8110598d>] ? do_path_lookup+0x5d/0xe0
[<ffffffff81106a7d>] do_filp_open+0x27d/0x7d0
[<ffffffff81114e91>] ? mntput_no_expire+0x71/0x1a0
[<ffffffff81112292>] ? alloc_fd+0xf2/0x140
[<ffffffff810f6214>] do_sys_open+0x64/0x110
[<ffffffff810f62eb>] sys_open+0x1b/0x20
[<ffffffff81002d3b>] system_call_fastpath+0x16/0x1b
Code: ff ff ff 48 8b 1b 48 8b 03 48 81 fb 80 8f 5e 81 0f 18 08 75 e5 48 c7 c7 60 8f 5e 81 e8 59 30 1f 00 31 c0 48 83 c4 08 5b c9 c3 55 <48> 83 bf 38 02 00 00 00 48 89 e5 74 07 31 f6 e8 2b fe ff ff c9
--
Jens Axboe
next prev parent reply other threads:[~2011-03-09 14:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 9:13 [PATCHSET] block: Convert block drivers to ->check_events(), take#2 Tejun Heo
2011-03-09 9:13 ` [PATCH 01/16] block: Don't implicitly trigger event check on disk_unblock_events() Tejun Heo
2011-03-09 9:13 ` [PATCH 02/16] block: Don't check events on close unless it was blocked Tejun Heo
2011-03-09 9:13 ` [PATCH 03/16] block: Don't check events while open is in progress Tejun Heo
2011-03-09 9:13 ` [PATCH 04/16] ide: Convert to bdops->check_events() Tejun Heo
2011-03-09 22:17 ` David Miller
2011-03-09 9:13 ` [PATCH 05/16] floppy,{ami|ata}flop: " Tejun Heo
2011-03-09 9:13 ` [PATCH 06/16] gdrom,viocd: " Tejun Heo
2011-03-09 9:13 ` [PATCH 07/16] paride: " Tejun Heo
2011-03-09 9:13 ` [PATCH 08/16] dac960: " Tejun Heo
2011-03-09 9:13 ` [PATCH 09/16] swim[3]: " Tejun Heo
2011-03-10 0:10 ` Benjamin Herrenschmidt
2011-03-09 9:13 ` [PATCH 10/16] ub: " Tejun Heo
2011-03-09 16:46 ` Pete Zaitcev
2011-03-09 16:58 ` Tejun Heo
2011-03-09 9:13 ` [PATCH 11/16] xsysace: " Tejun Heo
2011-03-09 9:13 ` [PATCH 12/16] i2o_block: " Tejun Heo
2011-03-09 9:13 ` [PATCH 13/16] s390/tape_block: " Tejun Heo
2011-03-09 9:13 ` [PATCH 14/16] umem: Drop dummy ->media_changed() Tejun Heo
2011-03-09 9:13 ` [PATCH 15/16] pktcdvd: Convert to bdops->check_events() Tejun Heo
2011-03-09 9:13 ` [PATCH 16/16] staging: " Tejun Heo
2011-03-09 9:20 ` [PATCHSET] block: Convert block drivers to ->check_events(), take#2 Jens Axboe
2011-03-09 14:49 ` Jens Axboe [this message]
2011-03-09 15:38 ` block: Fix oops caused by __blkdev_get() calling disk_unblock_events() with invalid @disk Tejun Heo
2011-03-09 18:26 ` Jens Axboe
2011-03-09 18:59 ` Tejun Heo
2011-03-09 19:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D779396.7050905@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=hch@infradead.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox