* Revert "irq: Add tracepoint to softirq_raise" - microblaze build
@ 2011-03-09 12:20 Michal Simek
2011-03-09 16:46 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-03-09 12:20 UTC (permalink / raw)
To: Frederic Weisbecker, LKML; +Cc: Steven Rostedt, Ingo Molnar
Hi Frederic,
I have compiled ftrace support for Microblaze and I have reached a compilation failure.
I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.
I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
It is likely any missing header or so.
Do you know what can be wrong?
Thanks,
Michal
[ALL ] CC kernel/trace/power-traces.o
[ALL ] In file included from
/mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
[ALL ] from include/linux/irq.h:27,
[ALL ] from include/asm-generic/hardirq.h:12,
[ALL ] from
/mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/hardirq.h:15,
[ALL ] from include/linux/hardirq.h:7,
[ALL ] from include/linux/ftrace_event.h:7,
[ALL ] from include/trace/ftrace.h:19,
[ALL ] from include/trace/define_trace.h:96,
[ALL ] from include/trace/events/power.h:240,
[ALL ] from kernel/trace/power-traces.c:14:
[ALL ] include/linux/interrupt.h: In function '__raise_softirq_irqoff':
[ERROR] include/linux/interrupt.h:413: error: implicit declaration of function 'trace_softirq_raise'
[ALL ] In file included from include/trace/ftrace.h:554,
[ALL ] from include/trace/define_trace.h:96,
[ALL ] from include/trace/events/power.h:240,
[ALL ] from kernel/trace/power-traces.c:14:
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_entry':
[ERROR] include/trace/events/irq.h:37: error: implicit declaration of function
'check_trace_callback_type_irq_handler_entry'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_exit':
[ERROR] include/trace/events/irq.h:67: error: implicit declaration of function
'check_trace_callback_type_irq_handler_exit'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_entry':
[ERROR] include/trace/events/irq.h:112: error: implicit declaration of function
'check_trace_callback_type_softirq_entry'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_exit':
[ERROR] include/trace/events/irq.h:126: error: implicit declaration of function
'check_trace_callback_type_softirq_exit'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_raise':
[ERROR] include/trace/events/irq.h:140: error: implicit declaration of function
'check_trace_callback_type_softirq_raise'
[ERROR] make[5]: *** [kernel/trace/power-traces.o] Error 1
[ERROR] make[4]: *** [kernel/trace] Error 2
[ERROR] make[3]: *** [kernel] Error 2
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Revert "irq: Add tracepoint to softirq_raise" - microblaze build
2011-03-09 12:20 Revert "irq: Add tracepoint to softirq_raise" - microblaze build Michal Simek
@ 2011-03-09 16:46 ` Steven Rostedt
2011-03-09 17:01 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2011-03-09 16:46 UTC (permalink / raw)
To: monstr; +Cc: Frederic Weisbecker, LKML, Ingo Molnar
On Wed, 2011-03-09 at 13:20 +0100, Michal Simek wrote:
> Hi Frederic,
>
> I have compiled ftrace support for Microblaze and I have reached a compilation failure.
>
> I bisected it and I found that
> "irq: Add tracepoint to softirq_raise"
> (sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
> caused it.
>
> I also found one thread which could be related.
> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
>
> It is likely any missing header or so.
>
> Do you know what can be wrong?
>
> Thanks,
> Michal
>
>
> [ALL ] CC kernel/trace/power-traces.o
> [ALL ] In file included from
> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
Is there a reason that arch/microblaze/include/asm/irq.h includes
"linux/interrupt.h"?
-- Steve
> [ALL ] from include/linux/irq.h:27,
> [ALL ] from include/asm-generic/hardirq.h:12,
> [ALL ] from
> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/hardirq.h:15,
> [ALL ] from include/linux/hardirq.h:7,
> [ALL ] from include/linux/ftrace_event.h:7,
> [ALL ] from include/trace/ftrace.h:19,
> [ALL ] from include/trace/define_trace.h:96,
> [ALL ] from include/trace/events/power.h:240,
> [ALL ] from kernel/trace/power-traces.c:14:
> [ALL ] include/linux/interrupt.h: In function '__raise_softirq_irqoff':
> [ERROR] include/linux/interrupt.h:413: error: implicit declaration of function 'trace_softirq_raise'
> [ALL ] In file included from include/trace/ftrace.h:554,
> [ALL ] from include/trace/define_trace.h:96,
> [ALL ] from include/trace/events/power.h:240,
> [ALL ] from kernel/trace/power-traces.c:14:
> [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_entry':
> [ERROR] include/trace/events/irq.h:37: error: implicit declaration of function
> 'check_trace_callback_type_irq_handler_entry'
> [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_exit':
> [ERROR] include/trace/events/irq.h:67: error: implicit declaration of function
> 'check_trace_callback_type_irq_handler_exit'
> [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_entry':
> [ERROR] include/trace/events/irq.h:112: error: implicit declaration of function
> 'check_trace_callback_type_softirq_entry'
> [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_exit':
> [ERROR] include/trace/events/irq.h:126: error: implicit declaration of function
> 'check_trace_callback_type_softirq_exit'
> [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_raise':
> [ERROR] include/trace/events/irq.h:140: error: implicit declaration of function
> 'check_trace_callback_type_softirq_raise'
> [ERROR] make[5]: *** [kernel/trace/power-traces.o] Error 1
> [ERROR] make[4]: *** [kernel/trace] Error 2
> [ERROR] make[3]: *** [kernel] Error 2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Revert "irq: Add tracepoint to softirq_raise" - microblaze build
2011-03-09 16:46 ` Steven Rostedt
@ 2011-03-09 17:01 ` Michal Simek
2011-03-09 17:12 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-03-09 17:01 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Frederic Weisbecker, LKML, Ingo Molnar
Steven Rostedt wrote:
> On Wed, 2011-03-09 at 13:20 +0100, Michal Simek wrote:
>> Hi Frederic,
>>
>> I have compiled ftrace support for Microblaze and I have reached a compilation failure.
>>
>> I bisected it and I found that
>> "irq: Add tracepoint to softirq_raise"
>> (sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
>> caused it.
>>
>> I also found one thread which could be related.
>> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
>>
>> It is likely any missing header or so.
>>
>> Do you know what can be wrong?
>>
>> Thanks,
>> Michal
>>
>>
>> [ALL ] CC kernel/trace/power-traces.o
>> [ALL ] In file included from
>> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
>
> Is there a reason that arch/microblaze/include/asm/irq.h includes
> "linux/interrupt.h"?
Yep, it is. I tried to add some headers not remove them.
Thanks,
Michal
P.S.: Do you want to create proper patch? If not, I will do it.
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Revert "irq: Add tracepoint to softirq_raise" - microblaze build
2011-03-09 17:01 ` Michal Simek
@ 2011-03-09 17:12 ` Steven Rostedt
2011-03-09 17:36 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2011-03-09 17:12 UTC (permalink / raw)
To: monstr; +Cc: Frederic Weisbecker, LKML, Ingo Molnar
On Wed, 2011-03-09 at 18:01 +0100, Michal Simek wrote:
> Steven Rostedt wrote:
> > On Wed, 2011-03-09 at 13:20 +0100, Michal Simek wrote:
> >> Hi Frederic,
> >>
> >> I have compiled ftrace support for Microblaze and I have reached a compilation failure.
> >>
> >> I bisected it and I found that
> >> "irq: Add tracepoint to softirq_raise"
> >> (sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
> >> caused it.
> >>
> >> I also found one thread which could be related.
> >> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
> >>
> >> It is likely any missing header or so.
> >>
> >> Do you know what can be wrong?
> >>
> >> Thanks,
> >> Michal
> >>
> >>
> >> [ALL ] CC kernel/trace/power-traces.o
> >> [ALL ] In file included from
> >> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
> >
> > Is there a reason that arch/microblaze/include/asm/irq.h includes
> > "linux/interrupt.h"?
>
> Yep, it is. I tried to add some headers not remove them.
Do you mean it is not needed? And removing it fixes the problem?
>
> Thanks,
> Michal
>
> P.S.: Do you want to create proper patch? If not, I will do it.
I rather not add patches to systems that I can't build, boot and test.
If removing the header works, just add a:
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Revert "irq: Add tracepoint to softirq_raise" - microblaze build
2011-03-09 17:12 ` Steven Rostedt
@ 2011-03-09 17:36 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2011-03-09 17:36 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Frederic Weisbecker, LKML, Ingo Molnar
Steven Rostedt wrote:
> On Wed, 2011-03-09 at 18:01 +0100, Michal Simek wrote:
>> Steven Rostedt wrote:
>>> On Wed, 2011-03-09 at 13:20 +0100, Michal Simek wrote:
>>>> Hi Frederic,
>>>>
>>>> I have compiled ftrace support for Microblaze and I have reached a compilation failure.
>>>>
>>>> I bisected it and I found that
>>>> "irq: Add tracepoint to softirq_raise"
>>>> (sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
>>>> caused it.
>>>>
>>>> I also found one thread which could be related.
>>>> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
>>>>
>>>> It is likely any missing header or so.
>>>>
>>>> Do you know what can be wrong?
>>>>
>>>> Thanks,
>>>> Michal
>>>>
>>>>
>>>> [ALL ] CC kernel/trace/power-traces.o
>>>> [ALL ] In file included from
>>>> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
>>> Is there a reason that arch/microblaze/include/asm/irq.h includes
>>> "linux/interrupt.h"?
>> Yep, it is. I tried to add some headers not remove them.
>
>
> Do you mean it is not needed? And removing it fixes the problem?
yes, removing that header fixed the problem. I will do more testing tomorrow.
>
> I rather not add patches to systems that I can't build, boot and test.
>
> If removing the header works, just add a:
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
ok.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-09 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 12:20 Revert "irq: Add tracepoint to softirq_raise" - microblaze build Michal Simek
2011-03-09 16:46 ` Steven Rostedt
2011-03-09 17:01 ` Michal Simek
2011-03-09 17:12 ` Steven Rostedt
2011-03-09 17:36 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox