Re: Revert "irq: Add tracepoint to softirq_raise" - microblaze build

[Michal Simek <monstr@monstr.eu>]

Steven Rostedt wrote:
> On Wed, 2011-03-09 at 18:01 +0100, Michal Simek wrote:
>> Steven Rostedt wrote:
>>> On Wed, 2011-03-09 at 13:20 +0100, Michal Simek wrote:
>>>> Hi Frederic,
>>>>
>>>> I have compiled ftrace support for Microblaze and I have reached a compilation failure.
>>>>
>>>> I bisected it and I found that
>>>> "irq: Add tracepoint to softirq_raise"
>>>> (sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
>>>> caused it.
>>>>
>>>> I also found one thread which could be related.
>>>> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
>>>>
>>>> It is likely any missing header or so.
>>>>
>>>> Do you know what can be wrong?
>>>>
>>>> Thanks,
>>>> Michal
>>>>
>>>>
>>>> [ALL  ]   CC      kernel/trace/power-traces.o
>>>> [ALL  ] In file included from 
>>>> /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
>>> Is there a reason that arch/microblaze/include/asm/irq.h includes
>>> "linux/interrupt.h"?
>> Yep, it is. I tried to add some headers not remove them.
> 
> 
> Do you mean it is not needed? And removing it fixes the problem?

yes, removing that header fixed the problem. I will do more testing tomorrow.

> 
> I rather not add patches to systems that I can't build, boot and test.
> 
> If removing the header works, just add a:
> 
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>

ok.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian