linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zachary Amsden <zamsden@redhat.com>
To: Nikola Ciprich <extmaillist@linuxbox.cz>
Cc: KVM list <kvm@vger.kernel.org>,
	Linux kernel list <linux-kernel@vger.kernel.org>,
	nikola.ciprich@linuxbox.cz, Avi Kivity <avi@redhat.com>,
	Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH] add missing guest clock update removed by	e48672fa25e879f7ae21785c7efd187738139593
Date: Wed, 09 Mar 2011 16:29:45 -0500	[thread overview]
Message-ID: <4D77F149.8020906@redhat.com> (raw)
In-Reply-To: <20110309193003.GB1762@pcnci.linuxbox.cz>

On 03/09/2011 02:30 PM, Nikola Ciprich wrote:
>> Can you try moving the kvm_make_request() inside the if conditional and
>> see if it that also fixes it?
>>      
> yes, changing to:
> if (unlikely(vcpu->cpu != cpu) || check_tsc_unstable()) {
> 	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
> 	/* Make sure TSC doesn't go backwards */
> 	s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 :
>
> is also OK.
>
> what about changing:
> if (check_tsc_unstable()) {
> 	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);
> 	vcpu->arch.tsc_catchup = 1;
> 	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
> }
>
> to:
>
> if (check_tsc_unstable()) {
> 	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);
> 	vcpu->arch.tsc_catchup = 1;
> }
> kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
>
> this fixes thinks for me as well..
> n.
> ?
>    

Can you send a patch which does that?  I think this is the correct fix.

Thanks,

Zach

  reply	other threads:[~2011-03-09 21:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 10:18 [PATCH] add missing guest clock update removed by e48672fa25e879f7ae21785c7efd187738139593 Nikola Ciprich
2011-03-08 19:58 ` Zachary Amsden
2011-03-09 19:30   ` Nikola Ciprich
2011-03-09 21:29     ` Zachary Amsden [this message]
2011-03-09 22:36       ` [PATCHv2] fix regression caused " Nikola Ciprich
2011-03-10  7:01         ` Zachary Amsden
2011-03-10  9:07         ` Avi Kivity
2011-03-25  8:20         ` Zachary Amsden
2011-03-26 14:47           ` Nikola Ciprich
2011-04-11 16:12           ` Nikola Ciprich
2011-04-12 15:36             ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D77F149.8020906@redhat.com \
    --to=zamsden@redhat.com \
    --cc=avi@redhat.com \
    --cc=extmaillist@linuxbox.cz \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikola.ciprich@linuxbox.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).