From: matthieu castet <castet.matthieu@free.fr>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
castet.matthieu@free.fr, tglx@linutronix.de,
sfr@canb.auug.org.au, hpa@linux.intel.com, rjw@sisk.pl
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/trampoline] x86, trampoline: Use the unified trampoline setup for ACPI wakeup
Date: Wed, 09 Mar 2011 23:41:37 +0100 [thread overview]
Message-ID: <4D780221.1030209@free.fr> (raw)
In-Reply-To: <tip-d1ee433539ea5963a8f946f3428b335d1c5fdb20@git.kernel.org>
Hi,
tip-bot for H. Peter Anvin a écrit :
> Commit-ID: d1ee433539ea5963a8f946f3428b335d1c5fdb20
> Gitweb: http://git.kernel.org/tip/d1ee433539ea5963a8f946f3428b335d1c5fdb20
> Author: H. Peter Anvin <hpa@linux.intel.com>
> AuthorDate: Mon, 14 Feb 2011 15:42:46 -0800
> Committer: H. Peter Anvin <hpa@linux.intel.com>
> CommitDate: Thu, 17 Feb 2011 21:05:06 -0800
>
> diff --git a/arch/x86/kernel/acpi/wakeup_rm.S b/arch/x86/kernel/acpi/wakeup_rm.S
> index 6ff3b57..6ce81ee 100644
> --- a/arch/x86/kernel/acpi/wakeup_rm.S
> +++ b/arch/x86/kernel/acpi/wakeup_rm.S
> @@ -2,9 +2,11 @@
> * Wrapper script for the realmode binary as a transport object
> * before copying to low memory.
> */
> - .section ".rodata","a"
> - .globl wakeup_code_start, wakeup_code_end
> -wakeup_code_start:
> +#include <asm/page_types.h>
> +
> + .section ".x86_trampoline","a"
> + .balign PAGE_SIZE
> + .globl acpi_wakeup_code
> +acpi_wakeup_code:
> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
> -wakeup_code_end:
> .size wakeup_code_start, .-wakeup_code_start
It doesn't build for me, Shouldn't you change this to
.size acpi_wakeup_code, .-acpi_wakeup_code ?
Matthieu
next prev parent reply other threads:[~2011-03-09 22:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 4:56 [RFC] x86: Unify allocation of low memory trampolines H. Peter Anvin
2011-02-18 5:19 ` [tip:x86/trampoline] x86, trampoline: Common infrastructure for " tip-bot for H. Peter Anvin
2011-02-18 12:16 ` Brian Gerst
2011-02-19 1:25 ` [tip:x86/trampoline] x86-64, trampoline: Remove unused variable tip-bot for H. Peter Anvin
2011-08-23 19:05 ` [tip:x86/trampoline] x86, trampoline: Common infrastructure for low memory trampolines Tony Luck
2011-08-23 19:12 ` H. Peter Anvin
2011-08-23 20:26 ` [PATCH] x86: remove some noise from boot log when starting cpus Luck, Tony
2012-02-20 16:08 ` Borislav Petkov
2012-02-22 10:33 ` Ingo Molnar
2012-02-22 10:57 ` Borislav Petkov
2012-02-22 11:29 ` Ingo Molnar
2012-02-22 18:06 ` [PATCH/resubmit] x86: Remove " Luck, Tony
2012-02-22 18:25 ` [tip:x86/cpu] " tip-bot for Luck, Tony
2012-02-22 20:34 ` [tip:x86/debug] x86/debug: Remove ancient debugging " tip-bot for Luck, Tony
2011-02-18 5:19 ` [tip:x86/trampoline] x86, trampoline: Use the unified trampoline setup for ACPI wakeup tip-bot for H. Peter Anvin
2011-03-09 22:41 ` matthieu castet [this message]
2011-03-10 0:07 ` Rafael J. Wysocki
2011-02-18 5:19 ` [tip:x86/trampoline] x86: Make the GDT_ENTRY() macro in <asm/segment.h> safe for assembly tip-bot for H. Peter Anvin
2011-02-18 5:20 ` [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file tip-bot for H. Peter Anvin
2011-02-18 12:31 ` Brian Gerst
2011-02-18 17:42 ` H. Peter Anvin
2011-02-19 1:25 ` [tip:x86/trampoline] x86, reboot: Fix the use of passed arguments in 32-bit BIOS reboot tip-bot for H. Peter Anvin
2011-04-29 15:16 ` [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file Alexey Zaytsev
2011-04-29 16:09 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D780221.1030209@free.fr \
--to=castet.matthieu@free.fr \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).