From: David Ahern <daahern@cisco.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 07/10] perf script: Move printing of 'common' data from print_event and rename
Date: Wed, 09 Mar 2011 17:04:31 -0700 [thread overview]
Message-ID: <4D78158F.6010403@cisco.com> (raw)
In-Reply-To: <20110309235007.GB2533@nowhere>
On 03/09/11 16:50, Frederic Weisbecker wrote:
>> +++ b/tools/perf/util/trace-event-parse.c
>> @@ -2648,63 +2648,8 @@ static void print_lat_fmt(void *data, int size __unused)
>> printf("%d", lock_depth);
>> }
>>
>> -/* taken from Linux, written by Frederic Weisbecker */
>> -static void print_graph_cpu(int cpu)
>> -{
>> - int i;
>> - int log10_this = log10_cpu(cpu);
>> - int log10_all = log10_cpu(cpus);
>> -
>> -
>> - /*
>> - * Start with a space character - to make it stand out
>> - * to the right a bit when trace output is pasted into
>> - * email:
>> - */
>> - printf(" ");
>> -
>> - /*
>> - * Tricky - we space the CPU field according to the max
>> - * number of online CPUs. On a 2-cpu system it would take
>> - * a maximum of 1 digit - on a 128 cpu system it would
>> - * take up to 3 digits:
>> - */
>> - for (i = 0; i < log10_all - log10_this; i++)
>> - printf(" ");
>> -
>> - printf("%d) ", cpu);
>> -}
>
> So, we indeed don't use the function graph tracer with perf yet.
> But there are fair chances we will in the future.
>
> So if we remove such code, I would prefer this to be made as
> a seperate commit. Something we can easily retrieve and revert
> in the future.
Once the references to the functions are removed, compile fails --
functions defined without a user.
I left the cpu arg into print_trace_event to avoid having to delete even
more code because of that.
David
>
> Other than that and the callchain bug, the whole series looks
> pretty good now.
>
> Thanks a lot!
next prev parent reply other threads:[~2011-03-10 0:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 18:31 [GIT PULL 00/10] perf/core fixes and improvements Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 01/10] perf session: Simplify evlist creation from perf.data header Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 02/10] perf evsel: Assume rest of perf_header_attr functions Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 03/10] perf header: Stop using 'self' Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 04/10] perf top: Fix events overflow in top command Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 05/10] perf top: Don't let events to eat up whole header line Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 06/10] perf script: Change process_event prototype Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 07/10] perf script: Move printing of 'common' data from print_event and rename Arnaldo Carvalho de Melo
2011-03-09 23:50 ` Frederic Weisbecker
2011-03-10 0:04 ` David Ahern [this message]
2011-03-10 0:10 ` Frederic Weisbecker
2011-03-10 0:11 ` David Ahern
2011-03-10 0:14 ` Frederic Weisbecker
2011-03-10 0:22 ` Frederic Weisbecker
2011-03-10 0:32 ` David Ahern
2011-03-10 0:50 ` Frederic Weisbecker
2011-03-09 18:31 ` [PATCH 08/10] perf script: Support custom field selection for output Arnaldo Carvalho de Melo
2011-03-09 18:31 ` [PATCH 09/10] perf script: Add support for dumping symbols Arnaldo Carvalho de Melo
2011-03-09 23:30 ` Frederic Weisbecker
2011-03-10 0:21 ` David Ahern
2011-03-09 18:31 ` [PATCH 10/10] perf script: Add support for H/W and S/W events Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D78158F.6010403@cisco.com \
--to=daahern@cisco.com \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox