From: Michal Marek <mmarek@suse.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: x86: kill binutils 2.16.x?
Date: Thu, 10 Mar 2011 09:50:22 +0100 [thread overview]
Message-ID: <4D7890CE.60800@suse.cz> (raw)
In-Reply-To: <20110303083035.GB14854@elte.hu>
On 3.3.2011 09:30, Ingo Molnar wrote:
> * H. Peter Anvin <hpa@zytor.com> wrote:
>> kbuild people: is there a way to test for a specific assembler version
>> in Kbuild (and error out the build for it?)
>
> Could we add a testcase for one of the more egregious breakages and bail out then?
> That way we don't have to get the version information right - broken prereleases
> would be covered as well.
>
> For example this sequence:
>
> .irp idx,0,1,2
> .if 0 > \idx
> .endif
> .endr
>
> Will break on 2.16, right? It builds fine on 2.20.
This seems to work for me with the binutils version from sles10 (even
with a vanilla build of binutils):
$ as -v <<EOF; echo $?
> .irp idx,0,1,2
> .if 0 > \idx
> .endif
> .endr
> EOF
GNU assembler version 2.16.91.0.5 (i586-suse-linux) using BFD version
2.16.91.0.5 20051219
0
$
So either the bug is fixed in that version already or you picked a wrong
example (or I did not understand what should fail here). But don't get
me wrong, I'm all for checking for actual bugs instead of innocent
version strings.
Michal
next prev parent reply other threads:[~2011-03-10 8:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 18:15 RFC: x86: kill binutils 2.16.x? H. Peter Anvin
2011-03-02 20:03 ` Andrew Morton
2011-03-02 20:11 ` H. Peter Anvin
2011-03-02 20:25 ` Sam Ravnborg
2011-03-02 20:30 ` Randy Dunlap
2011-03-02 21:28 ` Vegard Nossum
2011-03-02 21:29 ` H. Peter Anvin
2011-03-02 20:54 ` Thomas Gleixner
2011-03-02 21:02 ` H. Peter Anvin
2011-03-02 21:17 ` Thomas Gleixner
2011-03-02 22:59 ` H. Peter Anvin
2011-03-03 8:30 ` Ingo Molnar
2011-03-08 19:57 ` Kyle Moffett
2011-03-08 21:28 ` Benjamin Herrenschmidt
2011-03-08 21:56 ` Scott Wood
2011-03-08 21:59 ` Kyle Moffett
2011-03-08 23:13 ` Benjamin Herrenschmidt
2011-03-08 23:43 ` Kyle Moffett
2011-03-09 4:39 ` Segher Boessenkool
2011-03-10 8:50 ` Michal Marek [this message]
2011-03-10 8:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7890CE.60800@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox