From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
linux-arm-msm@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] msm: 8660: Add clock control regions to iomap
Date: Thu, 10 Mar 2011 18:40:08 +0300 [thread overview]
Message-ID: <4D78F0D8.7000408@ru.mvista.com> (raw)
In-Reply-To: <1299732274-10742-2-git-send-email-sboyd@codeaurora.org>
Hello.
On 10-03-2011 7:44, Stephen Boyd wrote:
> Change-Id: I9e72f10d0da1d6aaaaf7df85d33b998edf424f6f
This shouldn't be here.
> Signed-off-by: Stephen Boyd<sboyd@codeaurora.org>
[...]
> diff --git a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> index 3b19b8f..ddfc85b 100644
> --- a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> +++ b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> @@ -53,6 +53,14 @@
> #define MSM_TLMM_PHYS 0x00800000
> #define MSM_TLMM_SIZE SZ_16K
>
> +#define MSM_CLK_CTL_BASE IOMEM(0xFA010000)
> +#define MSM_CLK_CTL_PHYS 0x00900000
> +#define MSM_CLK_CTL_SIZE SZ_16K
Surrounding code separates the macro names from values by tabs, and you're
using spaces. Should be more consistent...
> +#define MSM_LPASS_CLK_CTL_BASE IOMEM(0xFA015000)
> +#define MSM_LPASS_CLK_CTL_PHYS 0x28000000
> +#define MSM_LPASS_CLK_CTL_SIZE SZ_4K
> +
> #define MSM_SHARED_RAM_BASE IOMEM(0xF0100000)
> #define MSM_SHARED_RAM_SIZE SZ_1M
WBR, Sergei
next prev parent reply other threads:[~2011-03-10 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 4:44 [PATCH 0/3] Peripheral image loader (PIL) Stephen Boyd
2011-03-10 4:44 ` [PATCH 1/3] msm: 8660: Add clock control regions to iomap Stephen Boyd
2011-03-10 15:40 ` Sergei Shtylyov [this message]
2011-03-10 20:12 ` David Brown
2011-03-10 20:19 ` Stephen Boyd
2011-03-10 4:44 ` [PATCH 2/3] msm: Peripheral Image Loader (PIL) driver Stephen Boyd
2011-03-16 10:20 ` Daniel Walker
2011-03-16 18:40 ` David Brown
2011-03-16 18:48 ` Saravana Kannan
2011-03-23 12:27 ` Daniel Walker
2011-03-23 12:37 ` Daniel Walker
2011-03-16 21:12 ` Bryan Huntsman
2011-03-10 4:44 ` [PATCH 3/3] msm: documentation: Add pil documentation Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D78F0D8.7000408@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox