public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: "Mário Isidoro" <marioisidoro@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH n_gsm] GSM Mux in non-transparent mode
Date: Fri, 11 Mar 2011 14:34:07 +0100	[thread overview]
Message-ID: <4D7A24CF.9070805@eukrea.com> (raw)
In-Reply-To: <1299724790.1800.135.camel@Paio>

Hi Mário,

On 10/03/2011 03:39, Mário Isidoro wrote:
> @@ -2661,9 +2725,12 @@ static int gsmtty_tiocmset(struct tty_struct
> *tty, struct file *filp,
>   	struct gsm_dlci *dlci = tty->driver_data;
>   	unsigned int modem_tx = dlci->modem_tx;
>
> -	modem_tx &= clear;
> +	modem_tx &= ~clear;
>   	modem_tx |= set;
>
good catch : this fix (and only this one in your patch) makes Telit modems 
work realiable here with ppp (which was failing before).
Tested on GC864-QUAD-V2, UC864-E and UC864-WD

Thanks !

Eric

  parent reply	other threads:[~2011-03-11 13:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  2:39 [PATCH n_gsm] GSM Mux in non-transparent mode Mário Isidoro
2011-03-10 11:06 ` Alan Cox
2011-03-10 16:30   ` Eric Bénard
2011-03-11 12:47   ` Mário Isidoro
2011-03-11 13:34 ` Eric Bénard [this message]
2011-03-11 15:27   ` Mário Isidoro
2011-03-11 17:00     ` Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7A24CF.9070805@eukrea.com \
    --to=eric@eukrea.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marioisidoro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox