From: Jens Axboe <axboe@kernel.dk>
To: scameron@beardog.cce.hp.com
Cc: mikem@beardog.cce.hp.com, akpm@linux-foundation.org,
thenzl@redhat.com, linux-kernel@vger.kernel.org,
smcameron@yahoo.com
Subject: Re: [PATCH] cciss: Add missing allocation in scsi_cmd_stack_setup and corresponding deallocation
Date: Fri, 11 Mar 2011 21:08:25 +0100 [thread overview]
Message-ID: <4D7A8139.3010101@kernel.dk> (raw)
In-Reply-To: <20110311194644.GE12760@beardog.cce.hp.com>
On 2011-03-11 20:46, scameron@beardog.cce.hp.com wrote:
> On Fri, Mar 11, 2011 at 08:09:39PM +0100, Jens Axboe wrote:
>> On 2011-03-10 21:22, Stephen M. Cameron wrote:
>>> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>>>
>>> This bit got lost somewhere along the way. Without this, panic.
>>
>> This doesn't apply cleanly, neither hunk. I hand applied it. Please let
>> me know what a patch is against in the future, if it doesn't apply
>> "anywhere".
>
> Oh... I see what happened.
>
> That patch was fixing something which was accidentally
> left out of this patch:
>
> http://marc.info/?l=linux-kernel&m=129840572232151&w=2
>
> which I mistakenly thought was present in 2.6.38-rc7,
> but it's not present (quite likely because without the
> missing bit, it causes a panic), It's sitting in my stack of
> patches still.
>
> [scameron@localhost linux-2.6.38-rc7]$ stg series | grep cciss
> + cciss-hoist-tag-masking-out-of-loop
> + cciss-inform-controller-we-are-using-32-bit-tags
> + cciss-mask-off-error-bits-before-calling-pci-free-consistent
> + cciss-remove-unnecessary-casts
> + cciss-fix-missed-command-status-value-CMD_UNABORTABLE
> + cciss-add-cciss_tape_cmds-module-parameter
> + cciss-fix-missing-initialization-in-scsi-cmd-stack-setup
> + cciss-export-resettable-host-attribute
> + cciss-fix-sense-data-copying-code
>
> What needs to happen is I combine cciss-add-cciss_tape_cmds-module-parameter
> and cciss-fix-missing-initialization-in-scsi-cmd-stack-setup into one
> working patch.
Please check what is missing for my for-2.6.39/drivers branch and send
me the patches.
--
Jens Axboe
prev parent reply other threads:[~2011-03-11 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 20:22 [PATCH] cciss: Add missing allocation in scsi_cmd_stack_setup and corresponding deallocation Stephen M. Cameron
2011-03-11 19:09 ` Jens Axboe
2011-03-11 19:46 ` scameron
2011-03-11 20:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7A8139.3010101@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=smcameron@yahoo.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox