From: Nikolai Kondrashov <spbnick@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Matthew Garrett <mjg@redhat.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver
Date: Fri, 11 Mar 2011 22:20:41 +0200 [thread overview]
Message-ID: <4D7A8419.6080107@gmail.com> (raw)
In-Reply-To: <20110311193433.GB14204@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On 03/11/2011 09:34 PM, Greg KH wrote:
> Ok, this shows you are not loading the driver I sent to you, this is the
> "original" one I sent, which will fail for your machine.
Sorry, I didn't know the old version was still there.
For some reason until I removed the staging samsung-laptop from the
Makefile, the new one didn't get installed.
> You need to build and install the one I sent you.
Done. So far tested on n230 only.
It fails to insert without "force" with the same message. With force it
installs, but doesn't seem to work, at least for brightness buttons.
Please find modinfo output and dmesg output attached.
Thank you :)
Sincerely,
Nick
[-- Attachment #2: n230_dmesg.txt --]
[-- Type: text/plain, Size: 13188 bytes --]
[ 252.249599] This computer supports SABI==f51cf
[ 252.249606] SABI header:
[ 252.249611] SMI Port Number = 0x00b2
[ 252.249615] SMI Interface Function = 0xc0
[ 252.249620] SMI enable memory buffer = 0xc1
[ 252.249625] SMI restore memory buffer = 0xc2
[ 252.249629] SABI data offset = 0x0f00
[ 252.249634] SABI data segment = 0xdf01
[ 252.249639] ifaceP = 0x000dff10
[ 252.249644] sabi_iface = c00dff10
[ 252.251359] backlight = 0x01
[ 252.252977] backlight should be off
[ 252.254667] backlight = 0x00
[ 253.258069] backlight should be on
[ 253.260227] backlight = 0x01
[ 253.262005] wireless led = 0x01
[ 253.264147] wireless led should be off
[ 253.264159] wl0: MAC Detected a change on the RF Disable Input 0x10000
[ 253.265929] wireless led = 0x00
[ 254.148087] ops->tx called while down
[ 254.148101] ops->tx called while down
[ 254.148108] ops->tx called while down
[ 254.148114] ops->tx called while down
[ 254.148120] ops->tx called while down
[ 254.148126] ops->tx called while down
[ 254.148132] ops->tx called while down
[ 254.148137] ops->tx called while down
[ 254.148143] ops->tx called while down
[ 254.148149] ops->tx called while down
[ 254.148155] ops->tx called while down
[ 254.148161] ------------[ cut here ]------------
[ 254.148212] WARNING: at /home/nick/projects/kernel.org/linus/linux-2.6/net/mac80211/tx.c:1490 ieee80211_tx+0x16c/0x18a [mac80211]()
[ 254.148222] Hardware name: N230
[ 254.148228] tx refused but queue active
[ 254.148234] Modules linked in: samsung_laptop(+) aes_i586 aes_generic i915 drm_kms_helper drm i2c_algo_bit parport_pc ppdev lp parport sco acpi_cpufreq mperf bridge stp cpufreq_stats bnep cpufreq_userspace cpufreq_conservative cpufreq_powersave rfcomm l2cap vboxnetadp vboxnetflt vboxdrv uinput fuse ext4 jbd2 crc16 loop dm_crypt dm_mod arc4 ecb snd_hda_codec_realtek snd_hda_intel brcm80211(C) snd_hda_codec uvcvideo btusb joydev videodev snd_hwdep snd_pcm mac80211 snd_seq snd_timer snd_seq_device snd cfg80211 evdev bluetooth i2c_i801 v4l1_compat tpm_tis soundcore snd_page_alloc tpm video psmouse i2c_core tpm_bios rfkill processor output pcspkr battery button serio_raw shpchp pci_hotplug ac ext3 jbd mbcache raid10 raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx raid1 raid0 multipath linear md_mod sd_mod crc_t10dif ahci uhci_hcd libahci libata ehci_hcd usbcore scsi_mod sky2 thermal thermal_sys nls_base [last unloaded: samsung_laptop]
[ 254.148486] Pid: 189, comm: kworker/u:2 Tainted: G WC 2.6.37+ #3
[ 254.148493] Call Trace:
[ 254.148511] [<c102f079>] ? warn_slowpath_common+0x6a/0x7b
[ 254.148553] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.148567] [<c102f0f0>] ? warn_slowpath_fmt+0x28/0x2c
[ 254.148608] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.148653] [<f87c454b>] ? ieee80211_xmit+0x184/0x18c [mac80211]
[ 254.148668] [<c11dcca7>] ? __alloc_skb+0x4c/0xda
[ 254.148709] [<f87c458f>] ? ieee80211_tx_skb+0x3c/0x43 [mac80211]
[ 254.148744] [<f87b5441>] ? ieee80211_offchannel_stop_station+0xcf/0xea [mac80211]
[ 254.148779] [<f87b5078>] ? ieee80211_scan_work+0x340/0x418 [mac80211]
[ 254.148794] [<c10403b1>] ? process_one_work+0x181/0x25e
[ 254.148830] [<f87b4d38>] ? ieee80211_scan_work+0x0/0x418 [mac80211]
[ 254.148843] [<c1041907>] ? worker_thread+0xf3/0x1f4
[ 254.148855] [<c1041814>] ? worker_thread+0x0/0x1f4
[ 254.148866] [<c1043f49>] ? kthread+0x63/0x68
[ 254.148877] [<c1043ee6>] ? kthread+0x0/0x68
[ 254.148890] [<c100353e>] ? kernel_thread_helper+0x6/0x10
[ 254.148899] ---[ end trace e9ed04a305514141 ]---
[ 254.248185] ops->tx called while down
[ 254.248199] ops->tx called while down
[ 254.248208] ops->tx called while down
[ 254.248216] ops->tx called while down
[ 254.248224] ops->tx called while down
[ 254.248232] ops->tx called while down
[ 254.248242] ops->tx called while down
[ 254.248250] ops->tx called while down
[ 254.248258] ops->tx called while down
[ 254.248266] ops->tx called while down
[ 254.248273] ops->tx called while down
[ 254.248281] ------------[ cut here ]------------
[ 254.248342] WARNING: at /home/nick/projects/kernel.org/linus/linux-2.6/net/mac80211/tx.c:1490 ieee80211_tx+0x16c/0x18a [mac80211]()
[ 254.248357] Hardware name: N230
[ 254.248365] tx refused but queue active
[ 254.248373] Modules linked in: samsung_laptop(+) aes_i586 aes_generic i915 drm_kms_helper drm i2c_algo_bit parport_pc ppdev lp parport sco acpi_cpufreq mperf bridge stp cpufreq_stats bnep cpufreq_userspace cpufreq_conservative cpufreq_powersave rfcomm l2cap vboxnetadp vboxnetflt vboxdrv uinput fuse ext4 jbd2 crc16 loop dm_crypt dm_mod arc4 ecb snd_hda_codec_realtek snd_hda_intel brcm80211(C) snd_hda_codec uvcvideo btusb joydev videodev snd_hwdep snd_pcm mac80211 snd_seq snd_timer snd_seq_device snd cfg80211 evdev bluetooth i2c_i801 v4l1_compat tpm_tis soundcore snd_page_alloc tpm video psmouse i2c_core tpm_bios rfkill processor output pcspkr battery button serio_raw shpchp pci_hotplug ac ext3 jbd mbcache raid10 raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx raid1 raid0 multipath linear md_mod sd_mod crc_t10dif ahci uhci_hcd libahci libata ehci_hcd usbcore scsi_mod sky2 thermal thermal_sys nls_base [last unloaded: samsung_laptop]
[ 254.248707] Pid: 189, comm: kworker/u:2 Tainted: G WC 2.6.37+ #3
[ 254.248719] Call Trace:
[ 254.248743] [<c102f079>] ? warn_slowpath_common+0x6a/0x7b
[ 254.248803] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.248822] [<c102f0f0>] ? warn_slowpath_fmt+0x28/0x2c
[ 254.248881] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.248947] [<f87c454b>] ? ieee80211_xmit+0x184/0x18c [mac80211]
[ 254.248968] [<c11dcca7>] ? __alloc_skb+0x4c/0xda
[ 254.249025] [<f87c458f>] ? ieee80211_tx_skb+0x3c/0x43 [mac80211]
[ 254.249076] [<f87b51c2>] ? ieee80211_offchannel_return+0x72/0x158 [mac80211]
[ 254.249132] [<f87b4686>] ? __ieee80211_scan_completed_finish+0x3c/0x7b [mac80211]
[ 254.249154] [<c10403b1>] ? process_one_work+0x181/0x25e
[ 254.249206] [<f87b4d38>] ? ieee80211_scan_work+0x0/0x418 [mac80211]
[ 254.249225] [<c1041907>] ? worker_thread+0xf3/0x1f4
[ 254.249242] [<c1041814>] ? worker_thread+0x0/0x1f4
[ 254.249257] [<c1043f49>] ? kthread+0x63/0x68
[ 254.249272] [<c1043ee6>] ? kthread+0x0/0x68
[ 254.249288] [<c100353e>] ? kernel_thread_helper+0x6/0x10
[ 254.249300] ---[ end trace e9ed04a305514142 ]---
[ 254.250639] ops->tx called while down
[ 254.250654] ops->tx called while down
[ 254.250663] ops->tx called while down
[ 254.250671] ops->tx called while down
[ 254.250679] ops->tx called while down
[ 254.250687] ops->tx called while down
[ 254.250695] ops->tx called while down
[ 254.250704] ops->tx called while down
[ 254.250712] ops->tx called while down
[ 254.250720] ops->tx called while down
[ 254.250728] ops->tx called while down
[ 254.250736] ------------[ cut here ]------------
[ 254.250797] WARNING: at /home/nick/projects/kernel.org/linus/linux-2.6/net/mac80211/tx.c:1490 ieee80211_tx+0x16c/0x18a [mac80211]()
[ 254.250812] Hardware name: N230
[ 254.250821] tx refused but queue active
[ 254.250829] Modules linked in: samsung_laptop(+) aes_i586 aes_generic i915 drm_kms_helper drm i2c_algo_bit parport_pc ppdev lp parport sco acpi_cpufreq mperf bridge stp cpufreq_stats bnep cpufreq_userspace cpufreq_conservative cpufreq_powersave rfcomm l2cap vboxnetadp vboxnetflt vboxdrv uinput fuse ext4 jbd2 crc16 loop dm_crypt dm_mod arc4 ecb snd_hda_codec_realtek snd_hda_intel brcm80211(C) snd_hda_codec uvcvideo btusb joydev videodev snd_hwdep snd_pcm mac80211 snd_seq snd_timer snd_seq_device snd cfg80211 evdev bluetooth i2c_i801 v4l1_compat tpm_tis soundcore snd_page_alloc tpm video psmouse i2c_core tpm_bios rfkill processor output pcspkr battery button serio_raw shpchp pci_hotplug ac ext3 jbd mbcache raid10 raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx raid1 raid0 multipath linear md_mod sd_mod crc_t10dif ahci uhci_hcd libahci libata ehci_hcd usbcore scsi_mod sky2 thermal thermal_sys nls_base [last unloaded: samsung_laptop]
[ 254.251160] Pid: 189, comm: kworker/u:2 Tainted: G WC 2.6.37+ #3
[ 254.251171] Call Trace:
[ 254.251195] [<c102f079>] ? warn_slowpath_common+0x6a/0x7b
[ 254.251256] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.251277] [<c102f0f0>] ? warn_slowpath_fmt+0x28/0x2c
[ 254.251335] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.251401] [<f87c454b>] ? ieee80211_xmit+0x184/0x18c [mac80211]
[ 254.251459] [<f87c4801>] ? ieee80211_probereq_get+0xd7/0xeb [mac80211]
[ 254.251516] [<f87c458f>] ? ieee80211_tx_skb+0x3c/0x43 [mac80211]
[ 254.251577] [<f87c759c>] ? ieee80211_send_probe_req+0xdb/0xeb [mac80211]
[ 254.251634] [<f87b8b84>] ? ieee80211_mgd_probe_ap_send+0x35/0x6e [mac80211]
[ 254.251686] [<f87b9c13>] ? ieee80211_mgd_probe_ap+0xac/0xba [mac80211]
[ 254.251708] [<c10403b1>] ? process_one_work+0x181/0x25e
[ 254.251763] [<f87b9c21>] ? ieee80211_sta_monitor_work+0x0/0xc [mac80211]
[ 254.251783] [<c1041907>] ? worker_thread+0xf3/0x1f4
[ 254.251800] [<c1041814>] ? worker_thread+0x0/0x1f4
[ 254.251816] [<c1043f49>] ? kthread+0x63/0x68
[ 254.251831] [<c1043ee6>] ? kthread+0x0/0x68
[ 254.251848] [<c100353e>] ? kernel_thread_helper+0x6/0x10
[ 254.251862] ---[ end trace e9ed04a305514143 ]---
[ 254.269440] wireless led should be on
[ 254.270687] wireless led = 0x01
[ 254.271941] brightness = 0x08
[ 254.748101] ops->tx called while down
[ 254.748114] ops->tx called while down
[ 254.748121] ops->tx called while down
[ 254.748127] ops->tx called while down
[ 254.748132] ops->tx called while down
[ 254.748138] ops->tx called while down
[ 254.748144] ops->tx called while down
[ 254.748150] ops->tx called while down
[ 254.748155] ops->tx called while down
[ 254.748161] ops->tx called while down
[ 254.748167] ops->tx called while down
[ 254.748173] ------------[ cut here ]------------
[ 254.748225] WARNING: at /home/nick/projects/kernel.org/linus/linux-2.6/net/mac80211/tx.c:1490 ieee80211_tx+0x16c/0x18a [mac80211]()
[ 254.748235] Hardware name: N230
[ 254.748241] tx refused but queue active
[ 254.748247] Modules linked in: samsung_laptop aes_i586 aes_generic i915 drm_kms_helper drm i2c_algo_bit parport_pc ppdev lp parport sco acpi_cpufreq mperf bridge stp cpufreq_stats bnep cpufreq_userspace cpufreq_conservative cpufreq_powersave rfcomm l2cap vboxnetadp vboxnetflt vboxdrv uinput fuse ext4 jbd2 crc16 loop dm_crypt dm_mod arc4 ecb snd_hda_codec_realtek snd_hda_intel brcm80211(C) snd_hda_codec uvcvideo btusb joydev videodev snd_hwdep snd_pcm mac80211 snd_seq snd_timer snd_seq_device snd cfg80211 evdev bluetooth i2c_i801 v4l1_compat tpm_tis soundcore snd_page_alloc tpm video psmouse i2c_core tpm_bios rfkill processor output pcspkr battery button serio_raw shpchp pci_hotplug ac ext3 jbd mbcache raid10 raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx raid1 raid0 multipath linear md_mod sd_mod crc_t10dif ahci uhci_hcd libahci libata ehci_hcd usbcore scsi_mod sky2 thermal thermal_sys nls_base [last unloaded: samsung_laptop]
[ 254.748499] Pid: 189, comm: kworker/u:2 Tainted: G WC 2.6.37+ #3
[ 254.748506] Call Trace:
[ 254.748525] [<c102f079>] ? warn_slowpath_common+0x6a/0x7b
[ 254.748567] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.748581] [<c102f0f0>] ? warn_slowpath_fmt+0x28/0x2c
[ 254.748622] [<f87c43a9>] ? ieee80211_tx+0x16c/0x18a [mac80211]
[ 254.748666] [<f87c454b>] ? ieee80211_xmit+0x184/0x18c [mac80211]
[ 254.748705] [<f87c4801>] ? ieee80211_probereq_get+0xd7/0xeb [mac80211]
[ 254.748745] [<f87c458f>] ? ieee80211_tx_skb+0x3c/0x43 [mac80211]
[ 254.748784] [<f87c759c>] ? ieee80211_send_probe_req+0xdb/0xeb [mac80211]
[ 254.748821] [<f87b8b84>] ? ieee80211_mgd_probe_ap_send+0x35/0x6e [mac80211]
[ 254.748857] [<f87b8c4b>] ? ieee80211_sta_work+0x8e/0x125 [mac80211]
[ 254.748871] [<c10403b1>] ? process_one_work+0x181/0x25e
[ 254.748909] [<f87bcd13>] ? ieee80211_iface_work+0x0/0x266 [mac80211]
[ 254.748922] [<c1041907>] ? worker_thread+0xf3/0x1f4
[ 254.748934] [<c1041814>] ? worker_thread+0x0/0x1f4
[ 254.748945] [<c1043f49>] ? kthread+0x63/0x68
[ 254.748956] [<c1043ee6>] ? kthread+0x0/0x68
[ 254.748969] [<c100353e>] ? kernel_thread_helper+0x6/0x10
[ 254.748978] ---[ end trace e9ed04a305514144 ]---
[ 256.748114] ieee80211 phy0: wlan0: No probe response from AP 00:02:61:48:cb:bc after 500ms, disconnecting.
[ 256.751615] Associated: False
[ 256.780783] cfg80211: Calling CRDA to update world regulatory domain
[ 257.873874] wlan0: authenticate with 00:02:61:48:cb:bc (try 1)
[ 257.875646] wlan0: authenticated
[ 257.875718] wlan0: associate with 00:02:61:48:cb:bc (try 1)
[ 257.883091] wlan0: RX AssocResp from 00:02:61:48:cb:bc (capab=0x431 status=0 aid=1)
[ 257.883098] wlan0: associated
[ 257.883990] Associated: True
[ 257.884551] cfg80211: Calling CRDA for country: NA
[-- Attachment #3: n230_modinfo.txt --]
[-- Type: text/plain, Size: 1788 bytes --]
filename: /lib/modules/2.6.37+/kernel/drivers/platform/x86/samsung-laptop.ko
license: GPL
description: Samsung Backlight driver
author: Greg Kroah-Hartman <gregkh@suse.de>
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*P460*:rn*P460*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*R70/R71*:rn*R70/R71*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*N145P/N250P/N260P*:rn*N145P/N250P/N260P*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*NF110/NF210/NF310*:rn*NF110/NF210/NF310*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*R530/R730*:rn*R530/R730*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*N150P/N210P/N220P*:rn*N150P/N210P/N220P*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*N150/N210/N220/N230*:rn*N150/N210/N220/N230*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*R519/R719*:rn*R519/R719*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*R518*:rn*R518*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*R410P*:rn*R460*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*X360*:rn*X360*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*SQ45S70S*:rn*SQ45S70S*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*NC10*:rn*NC10*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*X120/X170*:rn*X120/X170*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*X125*:rn*X125*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*N130*:rn*N130*:
alias: dmi*:svn*SAMSUNGELECTRONICSCO.,LTD.*:pn*N128*:rn*N128*:
depends: rfkill
vermagic: 2.6.37+ SMP mod_unload modversions 686
parm: force:Disable the DMI check and forces the driver to be loaded (bool)
parm: debug:Debug enabled or not (bool)
next prev parent reply other threads:[~2011-03-11 20:20 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 22:40 [PATCH] Platform: add Samsung Laptop platform driver Greg KH
2011-02-09 22:44 ` Randy Dunlap
2011-02-09 22:50 ` Greg KH
2011-02-09 22:58 ` Matthew Garrett
2011-02-09 22:50 ` Matthew Garrett
2011-02-09 23:02 ` Greg KH
2011-02-11 11:37 ` Richard Schütz
2011-02-11 15:22 ` Greg KH
2011-02-11 16:27 ` Richard Schütz
2011-02-25 21:01 ` Greg KH
2011-02-11 15:45 ` Matthew Garrett
2011-02-11 18:42 ` Greg KH
2011-02-16 10:06 ` Nikolai Kondrashov
2011-02-25 21:03 ` Greg KH
2011-02-25 21:49 ` Nikolai Kondrashov
2011-02-25 22:50 ` Greg KH
2011-03-10 7:00 ` Nikolai Kondrashov
2011-03-10 17:01 ` Greg KH
2011-03-10 17:13 ` Nikolai Kondrashov
2011-03-10 17:19 ` Greg KH
2011-03-10 17:28 ` Nikolai Kondrashov
2011-03-10 18:09 ` Greg KH
2011-03-10 21:05 ` Nikolai Kondrashov
2011-03-10 21:15 ` Greg KH
2011-03-11 7:12 ` Nikolai Kondrashov
2011-03-11 17:03 ` Greg KH
2011-03-11 19:07 ` Nikolai Kondrashov
2011-03-11 19:34 ` Greg KH
2011-03-11 20:20 ` Nikolai Kondrashov [this message]
2011-03-11 20:23 ` Nikolai Kondrashov
2011-03-11 20:35 ` Greg KH
2011-03-11 20:30 ` Greg KH
2011-03-13 10:03 ` Nikolai Kondrashov
2011-03-13 10:55 ` Richard Schütz
2011-03-13 13:02 ` Nikolai Kondrashov
2011-03-13 16:18 ` Greg KH
2011-03-13 17:49 ` Nikolai Kondrashov
2011-03-13 17:58 ` Greg KH
2011-03-13 16:17 ` Greg KH
2011-03-13 16:28 ` Matthew Garrett
2011-03-13 17:51 ` Nikolai Kondrashov
2011-03-13 17:50 ` Nikolai Kondrashov
-- strict thread matches above, loose matches on Subject: below --
2011-02-25 22:47 Greg KH
2011-02-27 15:36 Greg KH
2011-03-05 4:24 Greg KH
2011-03-11 17:43 ` Matthew Garrett
2011-03-11 19:35 ` Greg KH
2011-03-11 19:44 ` Matthew Garrett
2011-03-11 19:52 ` Greg KH
2011-03-11 19:55 ` Matthew Garrett
2011-03-14 15:18 ` Jörg-Volker Peetz
2011-03-11 17:57 Tommaso Massimi
2011-06-26 15:08 J Witteveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7A8419.6080107@gmail.com \
--to=spbnick@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox