From: roel <roel.kluin@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] SUNRPC: svc_register error overwritten in next iteration
Date: Sat, 12 Mar 2011 14:27:35 +0100 [thread overview]
Message-ID: <4D7B74C7.7060506@gmail.com> (raw)
The break is in the inner loop, the svc_register() error is overwritten
in the next iteration. Only the error in the last iteration is returned.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
net/sunrpc/svc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
Is this needed?
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 08e05a8..5fd08c0 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -889,6 +889,8 @@ int svc_register(const struct svc_serv *serv, const int family,
if (error < 0)
break;
}
+ if (error < 0)
+ break;
}
return error;
next reply other threads:[~2011-03-12 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 13:27 roel [this message]
2011-03-14 12:47 ` [PATCH] SUNRPC: svc_register error overwritten in next iteration Chuck Lever
2011-03-14 22:36 ` J. Bruce Fields
2011-03-15 15:43 ` Chuck Lever
2011-03-15 16:13 ` J. Bruce Fields
2011-03-15 16:54 ` Chuck Lever
2011-03-15 16:57 ` J. Bruce Fields
2011-03-15 21:34 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7B74C7.7060506@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox