From: Andy Green <andy@warmcat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
patches@linaro.org
Subject: Re: [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name
Date: Sun, 13 Mar 2011 13:53:17 +0000 [thread overview]
Message-ID: <4D7CCC4D.801@linaro.org> (raw)
In-Reply-To: <201103131351.36078.rjw@sisk.pl>
On 03/13/2011 12:51 PM, Somebody in the thread at some point said:
>> Okay. This is not a PC we are talking about.
>>
>> If the platform / board definition file is registering the USB hosts
>> synchronously at boot time, the driver is composed into the monolithic
>> kernel, there are no PCI busses or whatever on the SoC, the bus indexing
>> is totally deterministic. This is extremely common in the platform /
>> SoC case and is the case the patchset is targeted at. Even further, the
>> only time you'd use it is to reach a USB asset that is wired up the same
>> board permanently as well.
>>
>> Anyway this seems moot by now.
>
> However, if you add a new infrastructure like this, it should be at least
> usable on systems that you description doesn't apply to.
Sounds reasonable, except the platform data is coming from a
board-specific board definition file at boot-time to talk about assets
that are on fixed interfaces of a specific board. It's not really
applicable to wider generic bus use, just like platform_data usually
isn't and has to be targeted at "device at XYZ on I2C bus n" with
knowledge of what driver is bound to that device. Despite that
"impedence mismatch", it covers the SoC onboard USB asset case just fine
as it is.
If you mean though, that the patch series implements new configuration
options in usbnet that are anyway interesting to expose for the general
case, I can see the point but don't know enough about udev / usb
subsystem internals to suggest a way to expose the options nicely.
It's also commented the "right" thing to do is to have the driver set
the device up to wrong defaults like inappropriate interface name /
random MAC and have userland clean up the mess, rather than have the
board file ask the driver to set things appropriately.
-Andy
next prev parent reply other threads:[~2011-03-13 13:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 22:32 [RFC PATCH 0/4] PLATFORM: Support for async platform_data Andy Green
2011-03-12 22:32 ` [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name Andy Green
2011-03-12 23:29 ` Rafael J. Wysocki
2011-03-12 23:39 ` Andy Green
2011-03-13 1:03 ` Greg KH
2011-03-13 11:22 ` Andy Green
2011-03-13 12:51 ` Rafael J. Wysocki
2011-03-13 13:53 ` Andy Green [this message]
2011-03-13 16:58 ` Rafael J. Wysocki
2011-03-13 17:21 ` Andy Green
2011-03-13 20:45 ` Rafael J. Wysocki
2011-03-13 16:14 ` Greg KH
2011-03-13 17:26 ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 2/4] PLATFORM: Introduce registration function for async platform data maps Andy Green
2011-03-12 22:32 ` [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attach api Andy Green
2011-03-13 1:01 ` Greg KH
2011-03-13 10:41 ` Rafael J. Wysocki
2011-03-13 11:58 ` Andy Green
2011-03-13 12:53 ` Rafael J. Wysocki
2011-03-13 13:21 ` Andy Green
2011-03-13 16:15 ` Greg KH
2011-03-13 17:13 ` Andy Green
2011-03-13 17:48 ` Greg KH
2011-03-13 18:13 ` Andy Green
2011-03-13 23:26 ` Greg KH
2011-03-14 8:38 ` Andy Green
2011-03-14 20:54 ` Greg KH
2011-03-14 21:03 ` Alan Stern
2011-03-14 21:13 ` Greg KH
2011-03-14 21:10 ` Mark Brown
2011-03-14 21:59 ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 4/4] PLATFORM: Add some documentation to platform docs about async platform_data Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7CCC4D.801@linaro.org \
--to=andy@warmcat.com \
--cc=andy.green@linaro.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox