public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: Greg KH <greg@kroah.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@linaro.org
Subject: Re: [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attach api
Date: Sun, 13 Mar 2011 18:13:07 +0000	[thread overview]
Message-ID: <4D7D0933.9010502@linaro.org> (raw)
In-Reply-To: <20110313174811.GA11504@kroah.com>

On 03/13/2011 05:48 PM, Somebody in the thread at some point said:
> On Sun, Mar 13, 2011 at 05:13:31PM +0000, Andy Green wrote:
>> So when there's a bit more of Device Tree in evidence, are you going
>> to accept Device-tree based patches in usbnet etc along these lines,
>> or does that trigger the "do it in userspace" response, in which
>> case we are both wasting each others' time continuing to discuss
>> this at all?
>
> As mentioned numerous times before, network naming stuff happens in
> userspace, not in the kernel, so no matter what infrastructure is added,

The naming of that network interface happens in smsc95xx, in kernel: it 
uses a dodgy heuristic to choose between usb%d eth%d and others and gets 
it wrong in this case due to stuff outside its view.  There's nothing 
golden and wonderful about that which needs protecting from outside hints.

> insisting on naming the network device 'eth0' is not going to happen
> within the kernel.  Please use the tools we have today to do this with
> no kernel changes.
>
> As for other changes, it all depends on what you need to accomplish,
> right?  Those will be gladly reviewed on a case-by-case basis.

The immediate thing I would have liked to accomplish is to help smsc95xx 
make the right decision about naming and to use the MAC address in 
platform_data.  It seemed this was a general issue though, so I 
generalized how it was done.  But I don't have examples on my desk of 
boards with soldered-on USB other than smsc95xx Ethernet bridge.

At least, I am grateful we get down to brass tacks now and you clearly 
reject allowing the driver to take guidance to act more appropriately 
for its environment in the first place.  Therefore, this won't get fixed 
by Device Tree either.

So, we don't need to discuss this any further: thanks again for your time.

-Andy

  reply	other threads:[~2011-03-13 18:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12 22:32 [RFC PATCH 0/4] PLATFORM: Support for async platform_data Andy Green
2011-03-12 22:32 ` [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name Andy Green
2011-03-12 23:29   ` Rafael J. Wysocki
2011-03-12 23:39     ` Andy Green
2011-03-13  1:03       ` Greg KH
2011-03-13 11:22         ` Andy Green
2011-03-13 12:51           ` Rafael J. Wysocki
2011-03-13 13:53             ` Andy Green
2011-03-13 16:58               ` Rafael J. Wysocki
2011-03-13 17:21                 ` Andy Green
2011-03-13 20:45                   ` Rafael J. Wysocki
2011-03-13 16:14           ` Greg KH
2011-03-13 17:26             ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 2/4] PLATFORM: Introduce registration function for async platform data maps Andy Green
2011-03-12 22:32 ` [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attach api Andy Green
2011-03-13  1:01   ` Greg KH
2011-03-13 10:41     ` Rafael J. Wysocki
2011-03-13 11:58       ` Andy Green
2011-03-13 12:53         ` Rafael J. Wysocki
2011-03-13 13:21           ` Andy Green
2011-03-13 16:15             ` Greg KH
2011-03-13 17:13               ` Andy Green
2011-03-13 17:48                 ` Greg KH
2011-03-13 18:13                   ` Andy Green [this message]
2011-03-13 23:26                     ` Greg KH
2011-03-14  8:38                       ` Andy Green
2011-03-14 20:54                         ` Greg KH
2011-03-14 21:03                           ` Alan Stern
2011-03-14 21:13                             ` Greg KH
2011-03-14 21:10                           ` Mark Brown
2011-03-14 21:59                           ` Andy Green
2011-03-12 22:32 ` [RFC PATCH 4/4] PLATFORM: Add some documentation to platform docs about async platform_data Andy Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7D0933.9010502@linaro.org \
    --to=andy@warmcat.com \
    --cc=andy.green@linaro.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox