From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3 V2]trace-cmd: remove dead code
Date: Mon, 14 Mar 2011 10:39:34 +0800 [thread overview]
Message-ID: <4D7D7FE6.1090202@cn.fujitsu.com> (raw)
In-Reply-To: <1299768818.15854.343.camel@gandalf.stny.rr.com>
filter_cpu related code is totally dead.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
trace-read.c | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/trace-read.c b/trace-read.c
index 0e9ced8..88b576f 100644
--- a/trace-read.c
+++ b/trace-read.c
@@ -73,7 +73,6 @@ static const char *input_file;
static int multi_inputs;
static int max_file_size;
-static int filter_cpu = -1;
static int *filter_cpus;
static int nr_filter_cpus;
@@ -601,7 +600,7 @@ get_next_record(struct handle_list *handles, int *next_cpu)
do {
next = -1;
ts = 0;
- if (filter_cpus) {
+ if (nr_filter_cpus > 1) {
unsigned long long last_stamp = 0;
struct record *precord;
int next_cpu = -1;
@@ -619,9 +618,8 @@ get_next_record(struct handle_list *handles, int *next_cpu)
record = tracecmd_read_data(handles->handle, next_cpu);
else
record = NULL;
-
- } else if (filter_cpu >= 0) {
- cpu = filter_cpu;
+ } else if (nr_filter_cpus == 1) {
+ cpu = filter_cpus[0];
record = tracecmd_read_data(handles->handle, cpu);
} else
record = tracecmd_read_next_data(handles->handle, &cpu);
@@ -963,10 +961,7 @@ void trace_report (int argc, char **argv)
case 0:
switch(option_index) {
case 0: /* cpu */
- if (filter_cpu)
- add_cpu(optarg);
- else
- filter_cpu = atoi(optarg);
+ add_cpu(optarg);
break;
case 1: /* events */
print_events = 1;
--
1.7.4
prev parent reply other threads:[~2011-03-14 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 9:57 [PATCH 1/3]trace-cmd: remove dead code Lai Jiangshan
2011-03-10 14:53 ` Steven Rostedt
2011-03-14 2:30 ` Lai Jiangshan
2011-03-14 13:28 ` Steven Rostedt
2011-03-14 2:39 ` Lai Jiangshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7D7FE6.1090202@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox