From: Jeff Garzik <jgarzik@pobox.com>
To: Joe Perches <joe@perches.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ata: pata: Convert pr_*(DRV_NAME ...) to pr_fmt/pr_<level>
Date: Mon, 14 Mar 2011 02:56:53 -0400 [thread overview]
Message-ID: <4D7DBC35.90509@pobox.com> (raw)
In-Reply-To: <1296491964.4131.86.camel@Joe-Laptop>
On 01/31/2011 11:39 AM, Joe Perches wrote:
> Commit 40d69ba029c8d5de51aaeb5358999266c482d00a
> ("pata_hpt{37x|3x2n}: use pr_*(DRV_NAME ...) instead of printk(KERN_* ...)")
> used pr_<level>.
>
> Add #define pr_fmt and remove DRV_NAME.
> Increment driver version numbers.
>
> Signed-off-by: Joe Perches<joe@perches.com>
> ---
> On Mon, 2011-01-31 at 19:04 +0300, Sergei Shtylyov wrote:
>> Could you also increment the driver versions?
>
> At some point, the driver version is not very useful.
> You might consider removing them altogether.
>
> cheers, Joe
>
> drivers/ata/pata_hpt366.c | 7 ++++---
> drivers/ata/pata_hpt37x.c | 23 ++++++++++++-----------
> drivers/ata/pata_hpt3x2n.c | 13 +++++++------
> 3 files changed, 23 insertions(+), 20 deletions(-)
applied
prev parent reply other threads:[~2011-03-14 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201101310359.p0V3x41L010660@hera.kernel.org>
2011-01-31 4:34 ` [PATCH] ata: pata: Convert pr_*(DRV_NAME ...) to pr_fmt/pr_<level> Joe Perches
2011-01-31 16:04 ` Sergei Shtylyov
2011-01-31 16:39 ` [PATCH V2] " Joe Perches
2011-03-14 6:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7DBC35.90509@pobox.com \
--to=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox