From: Mike Christie <michaelc@cs.wisc.edu>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Boaz Harrosh <bharrosh@panasas.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Douglas Gilbert <dgilbert@interlog.com>,
Open iSCSI <open-iscsi@googlegroups.com>
Subject: Re: [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi
Date: Mon, 14 Mar 2011 17:13:30 -0500 [thread overview]
Message-ID: <4D7E930A.1010503@cs.wisc.edu> (raw)
In-Reply-To: <1300138856.28255.133.camel@haakon2.linux-iscsi.org>
On 03/14/2011 04:40 PM, Nicholas A. Bellinger wrote:
> On Mon, 2011-03-14 at 15:59 +0100, Christoph Hellwig wrote:
>> On Mon, Mar 14, 2011 at 04:56:58AM -0700, Nicholas A. Bellinger wrote:
>>> From: Nicholas Bellinger<nab@linux-iscsi.org>
>>>
>>> This patch renames the following iscsi_proto.h structures to avoid
>>> namespace issues with drivers/target/iscsi/iscsi_target_core.h:
>>>
>>> *) struct iscsi_cmd -> struct iscsi_scsi_cmd
>>
>> This name is not overly descriptive. Using _req/_rsp uniformly would make a
>> lot more sense.
>>
>
> Mmmm, fair point here.. I don't have a strong preference so I will
> defer to Mike and Hannes on this (open-iscsi CC'ed). Guys is this OK
> with you..?
>
Ok with me.
next prev parent reply other threads:[~2011-03-14 22:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 11:56 [RFC-v2 00/12] iSCSI target v4.1.0-rc1 series for .39 Nicholas A. Bellinger
2011-03-14 11:56 ` [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi Nicholas A. Bellinger
2011-03-14 14:59 ` Christoph Hellwig
2011-03-14 21:40 ` Nicholas A. Bellinger
2011-03-14 22:13 ` Mike Christie [this message]
2011-03-14 23:52 ` Nicholas A. Bellinger
2011-03-14 11:56 ` [RFC-v2 02/12] iscsi-target: Add primary iSCSI request/response state machine logic Nicholas A. Bellinger
2011-03-14 15:33 ` Christoph Hellwig
2011-03-15 0:17 ` Nicholas A. Bellinger
2011-03-15 10:15 ` Christoph Hellwig
2011-03-15 22:46 ` Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 03/12] iscsi-target: Add TCM v4 compatiable ConfigFS control plane Nicholas A. Bellinger
2011-03-15 0:54 ` Jesper Juhl
2011-03-15 4:47 ` Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 04/12] iscsi-target: Add configfs fabric dependent statistics Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 05/12] iscsi-target: Add TPG and Device logic Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 06/12] iscsi-target: Add iSCSI Login Negotiation and Parameter logic Nicholas A. Bellinger
2011-03-15 10:21 ` Christoph Hellwig
2011-03-15 22:55 ` Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 07/12] iscsi-target: Add CHAP Authentication support using libcrypto Nicholas A. Bellinger
2011-03-15 10:24 ` Christoph Hellwig
2011-03-15 22:56 ` Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 08/12] iscsi-target: Add Sequence/PDU list + DataIN response logic Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 09/12] iscsi-target: Add iSCSI Error Recovery Hierarchy support Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 10/12] iscsi-target: Add support for task management operations Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 11/12] iscsi-target: Add misc utility and debug logic Nicholas A. Bellinger
2011-03-15 10:27 ` Christoph Hellwig
2011-03-15 22:59 ` Nicholas A. Bellinger
2011-03-14 11:57 ` [RFC-v2 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level Nicholas A. Bellinger
2011-03-15 1:03 ` Jesper Juhl
2011-03-15 4:52 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7E930A.1010503@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=dgilbert@interlog.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=open-iscsi@googlegroups.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox