public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: musb as module broken in 2.6.38
Date: Wed, 16 Mar 2011 11:43:33 +0100	[thread overview]
Message-ID: <4D809455.9060901@ahsoftware.de> (raw)
In-Reply-To: <AF1846C5-739D-4598-83C0-34C3CBD5B9BB@ti.com>

Am 16.03.2011 11:38, schrieb Felipe Balbi:
> hi,
>
> On Mar 16, 2011, at 12:30 PM, Alexander Holler wrote:
>> Am 16.03.2011 11:24, schrieb Felipe Balbi:
>>> Hi,
>>>
>>> On Mar 16, 2011, at 12:17 PM, Alexander Holler wrote:
>>>>> static int __init omap2430_probe(struct platform_device *pdev)
>>>>
>>>> Neither omap2430_init() nor omap2430_probe() will be called here.
>>>
>>> and why is that ? It's even in sysfs already:
>>>
>>>>>> beagle linux # ls /sys/devices/platform/ | grep musb
>>>>>> musb-omap2430
>>
>> Don't know, I haven't written or changed the driver. ;)
>
> hehe, Just thought that you had something in mind already.
>
> probe() functions are called when, in case of platform_devices,
> the name matches with driver name. musb-omap2430 platform_device
> is allocated in arch/arm/mach-omap2/usb-musb.c, then musb-2430
> driver lives in drivers/usb/musb/omap2430.c. musb-2430 allocates a
> platform_device for musb-hdrc core driver.
>
> We did that because the same core is used in many different platforms
> (OMAP, discrete chips, ST-Ericsson, DaVinci, PCI cards, etc) so we
> needed to "abstract" platform-specific details such as clock handling
> and power management.
>
> There's still work to be done, for sure, e.g. the DMA part is still quite
> screwed up, but the drivers are correctly named which means they
> should be matching and probing. Now, musb-hdrc isn't probing, as
> you say, and I'd like to know why. I'll try to spend some time in
> it when I get back to the office.

I currently assume it's something with

subsys_initcall(omap2430_init);

Have to read about subsys_initcall() and why omap2430_init isn't called 
here.

Regards,

Alexander Holler

  reply	other threads:[~2011-03-16 10:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16  1:55 musb as module broken in 2.6.38 Alexander Holler
2011-03-16  9:03 ` Felipe Balbi
2011-03-16  9:47   ` Alexander Holler
2011-03-16  9:55     ` Felipe Balbi
2011-03-16 10:17       ` Alexander Holler
2011-03-16 10:24         ` Felipe Balbi
2011-03-16 10:30           ` Alexander Holler
2011-03-16 10:38             ` Felipe Balbi
2011-03-16 10:43               ` Alexander Holler [this message]
2011-03-16 10:48                 ` Felipe Balbi
2011-03-16 11:21                   ` Alexander Holler
2011-03-16 12:51                     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D809455.9060901@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox