From: Jens Axboe <jaxboe@fusionio.com>
To: Justin TerAvest <teravest@google.com>
Cc: "vgoyal@redhat.com" <vgoyal@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Don't update group weights when on service tree.
Date: Thu, 17 Mar 2011 16:13:44 +0100 [thread overview]
Message-ID: <4D822528.1040004@fusionio.com> (raw)
In-Reply-To: <1300374357-30686-1-git-send-email-teravest@google.com>
On 2011-03-17 16:05, Justin TerAvest wrote:
> Version 3 is updated to apply to for-2.6.39/core.
>
> For version 2, I took Vivek's advice and made sure we update the group
> weight from cfq_group_service_tree_add().
>
> If a weight was updated while a group is on the service tree, the
> calculation for the total weight of the service tree can be adjusted
> improperly, which either leads to bad service tree weights, or
> potentially crashes (if total_weight becomes 0).
>
> This patch defers updates to the weight until a group is off the service
> tree.
Thanks, applied. In the future, please remember to prefix the subject
line with the area of interest. This one should be:
cfq-iosched: bla bla bla
so that people going through the log knows what that patch is touching.
I added it for you here.
--
Jens Axboe
next prev parent reply other threads:[~2011-03-17 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 15:05 [PATCH v3] Don't update group weights when on service tree Justin TerAvest
2011-03-17 15:13 ` Jens Axboe [this message]
2011-03-21 19:27 ` Vivek Goyal
2011-03-21 20:15 ` Justin TerAvest
2011-03-21 20:23 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D822528.1040004@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox