public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, Jens Axboe <axboe@kernel.dk>,
	Robert Love <robert.w.love@intel.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	Neil Horman <nhorman@tuxdriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Tejun Heo <tj@kernel.org>, Jarek Poplawski <jarkao2@gmail.com>,
	linux-kernel@vger.kernel.org, devel@open-fcoe.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 09/36] net,rcu: convert call_rcu(ip_mc_socklist_reclaim) to kfree_rcu()
Date: Fri, 18 Mar 2011 11:45:08 +0800	[thread overview]
Message-ID: <4D82D544.6090509@cn.fujitsu.com> (raw)
In-Reply-To: <4D82D3FF.2080303@cn.fujitsu.com>



The rcu callback ip_mc_socklist_reclaim() just calls a kfree(),
so we use kfree_rcu() instead of the call_rcu(ip_mc_socklist_reclaim).

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
 net/ipv4/igmp.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index cf98a36..998dff0 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1850,14 +1850,6 @@ static int ip_mc_leave_src(struct sock *sk, struct ip_mc_socklist *iml,
 	return err;
 }
 
-
-static void ip_mc_socklist_reclaim(struct rcu_head *rp)
-{
-	kfree(container_of(rp, struct ip_mc_socklist, rcu));
-	/* sk_omem_alloc should have been decreased by the caller*/
-}
-
-
 /*
  *	Ask a socket to leave a group.
  */
@@ -1897,7 +1889,7 @@ int ip_mc_leave_group(struct sock *sk, struct ip_mreqn *imr)
 		rtnl_unlock();
 		/* decrease mem now to avoid the memleak warning */
 		atomic_sub(sizeof(*iml), &sk->sk_omem_alloc);
-		call_rcu(&iml->rcu, ip_mc_socklist_reclaim);
+		kfree_rcu(iml, rcu);
 		return 0;
 	}
 	if (!in_dev)
@@ -2312,7 +2304,7 @@ void ip_mc_drop_socket(struct sock *sk)
 			ip_mc_dec_group(in_dev, iml->multi.imr_multiaddr.s_addr);
 		/* decrease mem now to avoid the memleak warning */
 		atomic_sub(sizeof(*iml), &sk->sk_omem_alloc);
-		call_rcu(&iml->rcu, ip_mc_socklist_reclaim);
+		kfree_rcu(iml, rcu);
 	}
 	rtnl_unlock();
 }
-- 
1.7.4

  parent reply	other threads:[~2011-03-18  3:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4D82D071.5020703@cn.fujitsu.com>
2011-03-18  3:39 ` [PATCH 01/36] net,rcu: convert call_rcu(free_dm_hw_stat) to kfree_rcu() Lai Jiangshan
2011-03-18  3:41   ` [PATCH 02/36] scsi,rcu: convert call_rcu(fc_rport_free_rcu) " Lai Jiangshan
2011-03-22 17:28     ` Robert Love
2011-03-23  6:50       ` Paul E. McKenney
2011-03-23 11:22         ` Matthew Wilcox
2011-03-23 13:30           ` Paul E. McKenney
2011-03-23 14:05         ` James Bottomley
2011-03-23 22:24           ` Paul E. McKenney
2011-03-23 22:45             ` James Bottomley
2011-03-24  0:32               ` Paul E. McKenney
2011-03-23 23:19           ` Matthew Wilcox
2011-03-18  3:42   ` [PATCH 03/36] net,rcu: " Lai Jiangshan
2011-03-18 19:35     ` David Miller
2011-03-18  3:42   ` [PATCH 04/36] net,rcu: convert call_rcu(__leaf_info_free_rcu) " Lai Jiangshan
2011-03-18 19:35     ` David Miller
2011-03-18  3:42   ` [PATCH 05/36] block,rcu: convert call_rcu(disk_free_ptbl_rcu_cb) " Lai Jiangshan
2011-03-18  6:59     ` Jens Axboe
2011-03-18 11:20       ` Matthew Wilcox
2011-03-18  3:43   ` [PATCH 06/36] net,rcu: convert call_rcu(__gen_kill_estimator) " Lai Jiangshan
2011-03-18 19:35     ` David Miller
2011-03-18  3:44   ` [PATCH 07/36] net,rcu: convert call_rcu(ip_mc_list_reclaim) " Lai Jiangshan
2011-03-18 19:35     ` David Miller
2011-03-18  3:44   ` [PATCH 08/36] net,rcu: convert call_rcu(ip_sf_socklist_reclaim) " Lai Jiangshan
2011-03-18 19:35     ` David Miller
2011-03-18  3:45   ` Lai Jiangshan [this message]
2011-03-18 19:36     ` [PATCH 09/36] net,rcu: convert call_rcu(ip_mc_socklist_reclaim) " David Miller
2011-03-18 15:24   ` [PATCH 01/36] net,rcu: convert call_rcu(free_dm_hw_stat) " Neil Horman
2011-03-18 19:35   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D82D544.6090509@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=James.Bottomley@suse.de \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=devel@open-fcoe.org \
    --cc=eric.dumazet@gmail.com \
    --cc=jarkao2@gmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pekkas@netcore.fi \
    --cc=robert.w.love@intel.com \
    --cc=shemminger@vyatta.com \
    --cc=tj@kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox