* [PATCH 27/36] perf,rcu: convert call_rcu(swevent_hlist_release_rcu) to kfree_rcu()
@ 2011-03-18 4:08 Lai Jiangshan
2011-03-18 9:35 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2011-03-18 4:08 UTC (permalink / raw)
To: Paul E. McKenney, Ingo Molnar, Peter Zijlstra, Paul Mackerras,
Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel
The rcu callback swevent_hlist_release_rcu() just calls a kfree(),
so we use kfree_rcu() instead of the call_rcu(swevent_hlist_release_rcu).
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/perf_event.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index b0581bd..43b0410 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -5300,14 +5300,6 @@ swevent_hlist_deref(struct swevent_htable *swhash)
lockdep_is_held(&swhash->hlist_mutex));
}
-static void swevent_hlist_release_rcu(struct rcu_head *rcu_head)
-{
- struct swevent_hlist *hlist;
-
- hlist = container_of(rcu_head, struct swevent_hlist, rcu_head);
- kfree(hlist);
-}
-
static void swevent_hlist_release(struct swevent_htable *swhash)
{
struct swevent_hlist *hlist = swevent_hlist_deref(swhash);
@@ -5316,7 +5308,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash)
return;
rcu_assign_pointer(swhash->swevent_hlist, NULL);
- call_rcu(&hlist->rcu_head, swevent_hlist_release_rcu);
+ kfree_rcu(hlist, rcu_head);
}
static void swevent_hlist_put_cpu(struct perf_event *event, int cpu)
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 27/36] perf,rcu: convert call_rcu(swevent_hlist_release_rcu) to kfree_rcu()
2011-03-18 4:08 [PATCH 27/36] perf,rcu: convert call_rcu(swevent_hlist_release_rcu) to kfree_rcu() Lai Jiangshan
@ 2011-03-18 9:35 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2011-03-18 9:35 UTC (permalink / raw)
To: Lai Jiangshan
Cc: Paul E. McKenney, Ingo Molnar, Paul Mackerras,
Arnaldo Carvalho de Melo, linux-kernel
On Fri, 2011-03-18 at 12:08 +0800, Lai Jiangshan wrote:
>
> The rcu callback swevent_hlist_release_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(swevent_hlist_release_rcu).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/perf_event.c | 10 +---------
> 1 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index b0581bd..43b0410 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -5300,14 +5300,6 @@ swevent_hlist_deref(struct swevent_htable *swhash)
> lockdep_is_held(&swhash->hlist_mutex));
> }
>
> -static void swevent_hlist_release_rcu(struct rcu_head *rcu_head)
> -{
> - struct swevent_hlist *hlist;
> -
> - hlist = container_of(rcu_head, struct swevent_hlist, rcu_head);
> - kfree(hlist);
> -}
> -
> static void swevent_hlist_release(struct swevent_htable *swhash)
> {
> struct swevent_hlist *hlist = swevent_hlist_deref(swhash);
> @@ -5316,7 +5308,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash)
> return;
>
> rcu_assign_pointer(swhash->swevent_hlist, NULL);
> - call_rcu(&hlist->rcu_head, swevent_hlist_release_rcu);
> + kfree_rcu(hlist, rcu_head);
> }
>
> static void swevent_hlist_put_cpu(struct perf_event *event, int cpu)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-18 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-18 4:08 [PATCH 27/36] perf,rcu: convert call_rcu(swevent_hlist_release_rcu) to kfree_rcu() Lai Jiangshan
2011-03-18 9:35 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox