From: Jens Axboe <jaxboe@fusionio.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Lina Lu <lulina_nuaa@foxmail.com>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-throttle: Reset group slice when limits are changed
Date: Tue, 22 Mar 2011 21:55:29 +0100 [thread overview]
Message-ID: <4D890CC1.7070602@fusionio.com> (raw)
In-Reply-To: <20110322203319.GL3757@redhat.com>
On 2011-03-22 21:33, Vivek Goyal wrote:
> On Tue, Mar 15, 2011 at 01:54:56PM -0400, Vivek Goyal wrote:
>> Lina reported that if throttle limits are initially very high and then
>> dropped, then no new bio might be dispatched for a long time. And the
>> reason being that after dropping the limits we don't reset the existing
>> slice and do the rate calculation with new low rate and account the bios
>> dispatched at high rate. To fix it, reset the slice upon rate change.
>
> Hi Jens,
>
> Can you please apply this patch too.
Yep, applied. Thanks for the reminder :-)
--
Jens Axboe
prev parent reply other threads:[~2011-03-22 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 17:54 [PATCH] blk-throttle: Reset group slice when limits are changed Vivek Goyal
2011-03-18 15:11 ` Vivek Goyal
2011-03-22 20:33 ` Vivek Goyal
2011-03-22 20:55 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D890CC1.7070602@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulina_nuaa@foxmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox