From: Jens Axboe <jaxboe@fusionio.com>
To: Justin TerAvest <teravest@google.com>
Cc: "vgoyal@redhat.com" <vgoyal@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cfq-iosched: Don't clear queue stats when preempt.
Date: Wed, 23 Mar 2011 08:31:27 +0100 [thread overview]
Message-ID: <4D89A1CF.1050405@fusionio.com> (raw)
In-Reply-To: <1300833318-1072-1-git-send-email-teravest@google.com>
On 2011-03-22 23:35, Justin TerAvest wrote:
> For v2, I added back lines to cfq_preempt_queue() that were removed
> during updates for accounting unaccounted_time. Thanks for pointing out
> that I'd missed these, Vivek.
>
> Previous commit "cfq-iosched: Don't set active queue in preempt" wrongly
> cleared stats for preempting queues when it shouldn't have, because when
> we choose a queue to preempt, it still isn't necessarily scheduled next.
>
> Thanks to Vivek Goyal for figuring this out and understanding how the
> preemption code works.
Thanks to both of you, applied.
--
Jens Axboe
prev parent reply other threads:[~2011-03-23 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 22:35 [PATCH v2] cfq-iosched: Don't clear queue stats when preempt Justin TerAvest
2011-03-23 7:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D89A1CF.1050405@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox