From: Michal Marek <mmarek@suse.cz>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, greg@kroah.com, joe@perches.com,
akpm@linux-foundation.org
Subject: Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
Date: Wed, 23 Mar 2011 08:32:30 +0100 [thread overview]
Message-ID: <4D89A20E.3020604@suse.cz> (raw)
In-Reply-To: <4D894CD0.9030509@cn.fujitsu.com>
On 23.3.2011 02:28, Li Zefan wrote:
> Harry Wei wrote:
>> Hi us,
>> Clean up CodingStyle for scripts/kconfig/gconf.c.
>>
>
> What makes you think this is a bad style? Does Documentation/CodingStyle say
> so? Does checkpatch.pl make a complain? Do you really think this improves
> readability? I don't think so, and actually it makes the code worse.
This include can be removed completely, there is no config.h in kconfig.
Michal
prev parent reply other threads:[~2011-03-23 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 14:38 [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c Harry Wei
2011-03-23 1:28 ` Li Zefan
2011-03-23 7:00 ` Harry Wei
2011-03-23 7:32 ` Li Zefan
[not found] ` <AANLkTik9tv7Qroin6TucgK5HnY8JOhUuTg8uk4PugC0c@mail.gmail.com>
2011-03-23 12:27 ` Harry Wei
2011-03-23 7:32 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D89A20E.3020604@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox