From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <greg@kroah.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH 1/3] Add a kstrtobool function matching semantics of existing in kernel equivalents.
Date: Wed, 23 Mar 2011 19:11:33 +0000 [thread overview]
Message-ID: <4D8A45E5.5@cam.ac.uk> (raw)
In-Reply-To: <20110323184421.GA21728@kroah.com>
On 03/23/11 18:44, Greg KH wrote:
> On Wed, Mar 23, 2011 at 04:37:40PM +0000, Jonathan Cameron wrote:
>>> Ok, perhaps the name might need to be changed a bit, but the idea is
>>> still good to have. Please try again.
>>>
>> Any thoughts on what naming would work? Nothing immediately comes to mind
>> which is why I ended up pinching the kstrto* naming...
>>
>> reallysloppy_strtobool?
>> guessintent_strtobool?
>
> usr_strtobool? I don't care :)
That works for me. Anything usr related is clearly sloppy ;)
>
>> or the old classic underscore prefix to 'encourage' people to check what it does
>> before using it
>>
>> __strtobool?
>
> Ick, no, that implies that no one outside of this file should call it.
> Or it should be called with locks held or some such "special" thing.
> Don't do that...
I may have gotten a smidgen flippant ;)
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2011-03-23 19:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 13:39 [RFC PATCH 0/3] Introduce kstrtobool function Jonathan Cameron
2011-03-23 13:39 ` [PATCH 1/3] Add a kstrtobool function matching semantics of existing in kernel equivalents Jonathan Cameron
2011-03-23 13:54 ` David Sterba
2011-03-23 14:00 ` Jonathan Cameron
2011-03-23 15:30 ` Alexey Dobriyan
2011-03-23 16:01 ` Greg KH
2011-03-23 16:15 ` Jonathan Cameron
2011-03-23 16:23 ` Greg KH
2011-03-23 16:37 ` Jonathan Cameron
2011-03-23 18:44 ` Greg KH
2011-03-23 19:11 ` Jonathan Cameron [this message]
2011-03-23 13:39 ` [PATCH 2/3] debugfs: move to new kstrtobool function Jonathan Cameron
2011-03-23 20:20 ` Ryan Mallon
2011-03-24 10:53 ` Jonathan Cameron
2011-03-23 13:39 ` [PATCH 3/3] params.c: Use new kstrtobool implementation to processing boolean inputs Jonathan Cameron
2011-03-23 13:42 ` Jonathan Cameron
2011-03-24 0:34 ` [RFC PATCH 0/3] Introduce kstrtobool function Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A45E5.5@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=adobriyan@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox