From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: Lin Ming <ming.m.lin@intel.com>, Don Zickus <dzickus@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH -tip] kgdb, x86: Pull up NMI notifier handler priority
Date: Wed, 23 Mar 2011 23:32:33 +0300 [thread overview]
Message-ID: <4D8A58E1.5090509@openvz.org> (raw)
kgdb needs IPI to be sent and handled before perf
or anything else NMI, otherwise kgdb hangs with bootup
self-tests (found on P4 HT SMP machine). Raise its priority
so that we're called first in a notifier chain.
Reported-by: Don Zickus <dzickus@redhat.com>
Tested-by: Lin Ming <ming.m.lin@intel.com>
CC: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
Don, Jason, take a look please.
arch/x86/kernel/kgdb.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: linux-2.6.git/arch/x86/kernel/kgdb.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/kgdb.c
+++ linux-2.6.git/arch/x86/kernel/kgdb.c
@@ -592,9 +592,12 @@ static struct notifier_block kgdb_notifi
.notifier_call = kgdb_notify,
/*
- * Lowest-prio notifier priority, we want to be notified last:
+ * We might need to send an IPI and
+ * do cpu roundup before anything else
+ * in notifier chain so high priority
+ * is needed.
*/
- .priority = NMI_LOCAL_LOW_PRIOR,
+ .priority = NMI_LOCAL_HIGH_PRIOR,
};
/**
--
Cyrill
next reply other threads:[~2011-03-23 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 20:32 Cyrill Gorcunov [this message]
2011-03-23 21:16 ` [PATCH -tip] kgdb, x86: Pull up NMI notifier handler priority Don Zickus
2011-03-23 21:33 ` Cyrill Gorcunov
2011-03-24 3:30 ` Dongdong Deng
2011-03-24 5:24 ` Cyrill Gorcunov
2011-03-31 17:40 ` Jason Wessel
2011-03-31 20:25 ` Cyrill Gorcunov
2011-04-01 9:26 ` Dongdong Deng
2011-04-01 11:39 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A58E1.5090509@openvz.org \
--to=gorcunov@openvz.org \
--cc=dzickus@redhat.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox