From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Xavier Bachelot <xavier@bachelot.org>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] viafb: add VIA slapping capability
Date: Thu, 24 Mar 2011 22:11:23 +0100 [thread overview]
Message-ID: <4D8BB37B.9040204@gmx.de> (raw)
In-Reply-To: <4D8B9FBE.6030207@bachelot.org>
Xavier Bachelot schrieb:
> On 03/24/2011 05:13 PM, Florian Tobias Schandinat wrote:
>> This patch introduces dummy functions to execute when we don't know
>> what we should do (due to missing documentation). They do nothing
>> but print a nice message in the log explaining the situation.
>> To trigger this message initial power management support is
>> activated which might save a bit energy by disabling PLL and clock
>> if no device is configured to use them.
>>
>> Note: The message is only shown for the oldest IGPs CLE266 and K400
>> as for the other platforms there are reasonable assumptions
>> how it does (hopefully) work.
>>
>> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
>> ---
>
>> +static void dummy_set_clock_source(enum via_clksrc source, bool use_pll)
>> +{
>> + printk(KERN_INFO "Using undocumented set slock soure.\n%s", via_slap);
>
> 2 typos above.
Indeed. Thanks for pointing it out, fixed.
> Regards,
> Xavier
Regards,
Florian Tobias Schandinat
next prev parent reply other threads:[~2011-03-24 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 16:12 viafb clock patches - second round Florian Tobias Schandinat
2011-03-24 16:12 ` [PATCH 1/3] viafb: add primary/secondary clock on/off switches Florian Tobias Schandinat
2011-03-24 16:12 ` [PATCH 2/3] viafb: split clock and PLL code to an extra file Florian Tobias Schandinat
2011-03-24 16:13 ` [PATCH 3/3] viafb: add VIA slapping capability Florian Tobias Schandinat
2011-03-24 19:47 ` Xavier Bachelot
2011-03-24 21:11 ` Florian Tobias Schandinat [this message]
2011-03-24 21:32 ` [PATCH v2] " Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8BB37B.9040204@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xavier@bachelot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox