multiple definition of `show_mem'

multiple definition of `show_mem'

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Hello,

current mainline (v2.6.38-7210-gb81a618) on ARM/mxs has the following build failure:

> lib/lib.a(show_mem.o): In function `show_mem':
> .../linux-2.6/lib/show_mem.c:67: multiple definition of `show_mem'
> arch/arm/mm/built-in.o:.../linux-2.6/arch/arm/mm/init.c:82: first defined here
> make: *** [vmlinux.o] Error 1

After reverting these patches the kernel compiles...

cbf978bfb12d7deca97d7333f65eda0381a072de oom: suppress nodes that are not allowed from meminfo on page alloc failure
29423e77c06cee7d4e335ef4a7cbd949da978c91 oom: suppress show_mem() for many nodes in irq context on page alloc failure
ddd588b5dd55f14320379961e47683db4e4c1d90 oom: suppress nodes that are not allowed from meminfo on oom kill

No time to boot the kernel, though.

cheers, MArc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

RE: multiple definition of `show_mem'

[John Linn]

> -----Original Message-----
> From: linux-arm-kernel-bounces@lists.infradead.org
[mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Marc Kleine-Budde
> Sent: Thursday, March 24, 2011 9:21 AM
> To: LKML
> Cc: linux-arm-kernel; kernel@pengutronix.de; David Rientjes
> Subject: multiple definition of `show_mem'
> 
> Hello,
> 
> current mainline (v2.6.38-7210-gb81a618) on ARM/mxs has the following
build failure:
> 
> > lib/lib.a(show_mem.o): In function `show_mem':
> > .../linux-2.6/lib/show_mem.c:67: multiple definition of `show_mem'
> > arch/arm/mm/built-in.o:.../linux-2.6/arch/arm/mm/init.c:82: first
> > defined here
> > make: *** [vmlinux.o] Error 1

I'm seeing the same error for my patches for the new Xilinx ARM
platform.

> 
> After reverting these patches the kernel compiles...
> 
> cbf978bfb12d7deca97d7333f65eda0381a072de oom: suppress nodes that are
not allowed from meminfo on page
> alloc failure
> 29423e77c06cee7d4e335ef4a7cbd949da978c91 oom: suppress show_mem() for
many nodes in irq context on
> page alloc failure ddd588b5dd55f14320379961e47683db4e4c1d90 oom:
suppress nodes that are not allowed
> from meminfo on oom kill
> 
> No time to boot the kernel, though.

I did the same reverts and the kernel built and booted fine.

Thanks,
John

> 
> cheers, MArc
> 
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Re: multiple definition of `show_mem'

[David Rientjes]

On Thu, 24 Mar 2011, Marc Kleine-Budde wrote:

> Hello,
> 
> current mainline (v2.6.38-7210-gb81a618) on ARM/mxs has the following build failure:
> 
> > lib/lib.a(show_mem.o): In function `show_mem':
> > .../linux-2.6/lib/show_mem.c:67: multiple definition of `show_mem'
> > arch/arm/mm/built-in.o:.../linux-2.6/arch/arm/mm/init.c:82: first defined here
> > make: *** [vmlinux.o] Error 1
> 
> After reverting these patches the kernel compiles...
> 
> cbf978bfb12d7deca97d7333f65eda0381a072de oom: suppress nodes that are not allowed from meminfo on page alloc failure
> 29423e77c06cee7d4e335ef4a7cbd949da978c91 oom: suppress show_mem() for many nodes in irq context on page alloc failure
> ddd588b5dd55f14320379961e47683db4e4c1d90 oom: suppress nodes that are not allowed from meminfo on oom kill
> 
> No time to boot the kernel, though.
> 

Sorry about that, Marc.  I have a patch at

	http://marc.info/?l=linux-kernel&m=130100511521954

which should fix the issue for you (and I tested it with my arm cross 
compiler).

Re: multiple definition of `show_mem'

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On 03/24/2011 11:22 PM, David Rientjes wrote:
>> current mainline (v2.6.38-7210-gb81a618) on ARM/mxs has the following build failure:
>>
>>> lib/lib.a(show_mem.o): In function `show_mem':
>>> .../linux-2.6/lib/show_mem.c:67: multiple definition of `show_mem'
>>> arch/arm/mm/built-in.o:.../linux-2.6/arch/arm/mm/init.c:82: first defined here
>>> make: *** [vmlinux.o] Error 1

[..]

> Sorry about that, Marc.  I have a patch at
> 
> 	http://marc.info/?l=linux-kernel&m=130100511521954
> 
> which should fix the issue for you (and I tested it with my arm cross 
> compiler).

\o/ - the patch is already in mainline, boots like charm on my mx28evk.

regards, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

RE: multiple definition of `show_mem'

[John Linn]

> -----Original Message-----
> From: linux-arm-kernel-bounces@lists.infradead.org
[mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Marc Kleine-Budde
> Sent: Friday, March 25, 2011 5:07 AM
> To: David Rientjes
> Cc: linux-arm-kernel; LKML; kernel@pengutronix.de
> Subject: Re: multiple definition of `show_mem'
> 
> On 03/24/2011 11:22 PM, David Rientjes wrote:
> >> current mainline (v2.6.38-7210-gb81a618) on ARM/mxs has the
following build failure:
> >>
> >>> lib/lib.a(show_mem.o): In function `show_mem':
> >>> .../linux-2.6/lib/show_mem.c:67: multiple definition of `show_mem'
> >>> arch/arm/mm/built-in.o:.../linux-2.6/arch/arm/mm/init.c:82: first
> >>> defined here
> >>> make: *** [vmlinux.o] Error 1
> 
> [..]
> 
> > Sorry about that, Marc.  I have a patch at
> >
> > 	http://marc.info/?l=linux-kernel&m=130100511521954
> >
> > which should fix the issue for you (and I tested it with my arm
cross
> > compiler).
> 
> \o/ - the patch is already in mainline, boots like charm on my
mx28evk.

I pulled it, rebuilt without any issues, and it runs also on the Xilinx
platform.

Thanks,
John

> 
> regards, Marc
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.