Re: [PATCH] perf tools: Emit clearer message for sys_perf_event_open ENOENT return

Arnaldo Carvalho de Melo
2011-03-25T18:37:53Z

Em Fri, Mar 25, 2011 at 12:26:41PM -0600, David Ahern escreveu:
> On 03/25/11 12:08, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 25, 2011 at 12:05:50PM -0600, David Ahern escreveu:
> >> Resend of patch sent back in January 2011 in light of recent confusion around
> >> unsupported events for a given platform.
> >>
> >> Improve sys_perf_event_open ENOENT return handling in top and record, just
> >> like 5a3446b does for stat.
> >>
> >> Retry of Arnaldo's patch using error instead of die which allows the fallback
> >> from hardware cycles to software clock.
> >
> > Please use ui__warning(""...) as it will work in the TUI too.
>
> error() is consistent with current pattern. Is ui__warning the
> preference for new messages? Is that for perf-top only?

Yes, it is, it takes care of using TUI of doing it like error() does.
Eventually error(), etc will go away.

- Arnaldo