RE: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

Jeff_Cheng
2011-03-28T03:29:52Z

Hi Guanqun
The msleep is to try disable pop noise.
If you have better way to disable pop noise, please fix it.
Thanks.

-----Original Message-----
From: Lu Guanqun [mailto:guanqun.lu@intel.com]
Sent: Monday, March 28, 2011 10:53 AM
To: Arjan van de Ven; Jeff Cheng/WHQ/Wistron
Cc: meego-kernel@lists.meego.com; alan@linux.intel.com; Wu, Fengguang;
Tang, Feng; Fu, Michael; Wang, Xingchao; Koul, Vinod; Kp, Jeeja; Greg
Kroah-Hartman; Babu, Ramesh; R, Dharageswari;
devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO
line

On Mon, Mar 28, 2011 at 10:35:36AM +0800, Arjan van de Ven wrote:
> On 3/27/2011 7:29 PM, Lu Guanqun wrote:
> >
> > pr_debug("sst: powering dn nc_power_down ....\n");
> >
> > + if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE ||
> > + snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) {
> > + msleep(30);
> > + nc_set_amp_power(0);
> > + }
> > msleep(30);
>
> this double msleep sounds rather harsh... why do we need two of these
?
> (heck... why do we need ONE ?)
>

This is legacy code from Jeff Cheng's patch.
Jeff, could you provide some information on this line?

--
guanqun