Re: [Meego-kernel] [PATCH v9 1/2] mrst: export get_gpio_by_name() function

Alan Cox
2011-03-28T09:46:12Z

> Medfield and MRST are targeting phones. MIDs don't exist... not in this
> decade.

Well you can take that up with everyone else somewhere offlist, but the
standard naming being used for these devices as a group is mid_xxx, and
has been in the kernel several releases.

> if it was renamed to sfi_get_gpio_by_name() it might make SOME sense,
> but even then it's a
> gratuitous rename for a function that's already in the upstream kernel.

1. It needs a name that won't clash with anything else or confuse people

2. It shouldn't be exported in the first place but appearing in the PCI
data for the device.

If it must be exported then it definitely needs a rename.