Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

Greg KH
2011-03-28T05:51:00Z

On Mon, Mar 28, 2011 at 10:29:20AM +0800, Lu Guanqun wrote:
> This patch originates from Jeff Cheng's patch to enable the internal speaker.

I don't understand this, why is it in the changelog entry?

> On Moorestown platform, internal speaker's power line is connected to a GPIO
> line, this information is got from SFI GPIO table, so we need set it to 1 to
> enable the internal speaker, or set it to 0 to disable it.
>
> When we set the output device, we power on or off the internal speaker on demand.

What happens without this patch? Is this a feature you are adding to
the driver, or a bugfix?

thanks,

greg k-h