Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

Lu Guanqun
2011-03-28T02:54:44Z

On Mon, Mar 28, 2011 at 10:35:36AM +0800, Arjan van de Ven wrote:
> On 3/27/2011 7:29 PM, Lu Guanqun wrote:
> >
> > pr_debug("sst: powering dn nc_power_down ....\n");
> >
> > + if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE ||
> > + snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) {
> > + msleep(30);
> > + nc_set_amp_power(0);
> > + }
> > msleep(30);
>
> this double msleep sounds rather harsh... why do we need two of these ?
> (heck... why do we need ONE ?)
>

This is legacy code from Jeff Cheng's patch.
Jeff, could you provide some information on this line?

--
guanqun